Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Enrico Bianco

Enrico Bianco

Not a member

Enrico Bianco's latest activity

Sunday, May 16 2010
4563 Patch for incorrect template choice in ActionController::Responder was updated in Ruby on Rails
  • Enrico Bianco
    Enrico Bianco commented at 1:17 AM

    +1

    Applies cleanly against master, verified that the test fails without the provided code that fixes the issue (and that tests pass when it is in place).
4531 [PATCH] Pass rack the absolute path of server's pid file was updated in Ruby on Rails
  • Enrico Bianco
    Enrico Bianco commented at 12:52 AM

    +1

    Verified bug, patch applies cleanly to current Rails master (3afdfc35...) and rails s -d no longer fails silently.
4604 number_to_currency fails with "NoMethodError: undefined method `>=' for nil:N... was updated in Ruby on Rails
  • Enrico Bianco
    Enrico Bianco commented at 12:42 AM

    not reproducible in the latest master:

    ruby-1.8.7-p249 > foo.number_to_currency(101.00)
 => "$101.00"

ruby-1.9.1-p378 > foo.number_to_currency(101.00)
=> "$10...
2801 incorrect sql from has_many :through was updated in Ruby on Rails
  • Enrico Bianco
    Enrico Bianco commented at 12:35 AM

    +1 verified in current master.

    Here are my models:

    class User < ActiveRecord::Base
  has_many :position_mappings
end

    class PositionMapping < ActiveRecord::Ba...
3209 symbol value support for check_box_checked? was updated in Ruby on Rails
  • Enrico Bianco
    Enrico Bianco commented at 12:16 AM

    Oops, messed up the commit message. Let me try that again. >_<
1560 link_to in ActionView::TestCase uses ActionController::UrlRewriter's url_for ... was updated in Ruby on Rails
  • Enrico Bianco
    Enrico Bianco commented at 12:07 AM

    +1, not reproducible in master.

    The url_for method in ActionView::Helpers::UrlHelper also handles strings (complete with new auto-escaping functionality):
    (acti...
Saturday, May 15 2010
3209 symbol value support for check_box_checked? was updated in Ruby on Rails
  • Enrico Bianco
    Enrico Bianco commented at 11:52 PM

    I've attached Lena's patch, slightly edited so that it'll apply cleanly against the current master branch.
2165 support of html Attributes for options_for_select was updated in Ruby on Rails
  • Enrico Bianco
    Enrico Bianco commented at 10:59 PM

    +1, applies cleanly to current master, tests pass, comprehensive tests and documentation.
2110 StringInquirer not required in railties was updated in Ruby on Rails
  • Enrico Bianco
    Enrico Bianco commented at 10:43 PM

    not reproducible in current master

    I tested this using the following environment.rb in a test rails app:

    require File.expand_path('../boot', __FILE__)

require...
4600 Hash#index is deprecated at 'rake routes' was updated in Ruby on Rails
  • Enrico Bianco
    Enrico Bianco commented at 10:24 PM

    +1

    I've tested this in 1.8.7, 1.9.1, and 1.9.2-head by pushing it to a separate branch of my fork of rails and bringing it in to a sample application via bundle...