#4563 Patch for incorrect template choice in ActionController::Responder - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#4563 ✓resolved

Patch for incorrect template choice in ActionController::Responder

Reported by Darcy Laycock | May 9th, 2010 @ 01:30 PM

The current head version of the bundled ActionController::Responder has a bug
that causes it to render new even if the method is put when the method is overriden.

This was caused by recent (well, Rails 3.0.0.beta3) changes that introduced
request.request_method and it's counterparts alongside request.method, the former
being equivalent to the old version of the latter. Unfortunately, in this change
the responder didn't get updated to use the correct method (request_method_symbol
versus the incorrect method_symbol).

The attached patch fixes this and includes tests that reproduce the bug. It applies
cleanly on master as of May 9th, 2010.

rails3-responder-fix.patch 3 KB

Comments and changes to this ticket

Dan Pickett May 9th, 2010 @ 06:38 PM
- Tag changed from “action_controller, bug, patch, rails3, responder” to “action_controller, bug, bugmash, patch, rails3, responder”
You flagged this item as spam.
Diego Algorta May 15th, 2010 @ 06:54 PM
verified

Submitting a rebased patch for current master with no changes.
- rails3-responder-fix-rebased.patch 3 KB
You flagged this item as spam.
Michal Kuklis May 15th, 2010 @ 09:49 PM
+1 verified on master
You flagged this item as spam.
Enrico Bianco May 16th, 2010 @ 01:17 AM
+1

Applies cleanly against master, verified that the test fails without the provided code that fixes the issue (and that tests pass when it is in place).
You flagged this item as spam.
Antti Tarvainen May 23rd, 2010 @ 12:41 PM
I didn't notice this ticket, and created a patch too, attached. I am happy with Diego's solution, but here's an alternative for reference, with a slightly different way of testing.
- responder_with_method_override.diff 4.9 KB
You flagged this item as spam.
Darcy Laycock May 30th, 2010 @ 05:21 PM
Looks like http://github.com/rails/rails/commit/59d1c418be47694a5b79d860bced6f... fixes this independently so it can be ignored now.
Rohit Arondekar June 20th, 2010 @ 03:09 PM
- State changed from “new” to “resolved”