This project is archived and is in readonly mode.
[PATCH] Multiple Improvements to UJS Drivers
Reported by Quin Hoxie | February 10th, 2010 @ 09:04 AM | in 3.0.2
Brief summary of changes:
Prototype - http://github.com/qhoxie/prototype-ujs
4b8ae92 Remove event.element() in favor of event.findElement()
5a06bee Treat data-remote as a boolean attribute in selectors
339aa6a Only support href as url on non-form elements
jQuery - http://github.com/qhoxie/jquery-ujs
be329c5 Whitespace consistency
b17c7bb Only create csrf input if the data is provided
16363f7 Simplify metadata inputs to strings and a single call to
append()
0999420 Treat data-remote as a boolean attribute in selectors
5ae3f93 Better symmetry in negation of data-remote selector
2e8f578 Utilize dataType option to manage Accept header
de7011f Throw exception if no url is provided in the remote
call
Diffs are attached. I can break them out if necessary.
Comments and changes to this ticket
-
Yehuda Katz (wycats) February 10th, 2010 @ 11:46 AM
- Assigned user set to “Yehuda Katz (wycats)”
- Milestone cleared.
@quin can you rebase the jQuery patch for master?
-
Quin Hoxie February 10th, 2010 @ 05:36 PM
- Assigned user cleared.
It looks like the latest commit on rails' master is http://github.com/rails/jquery-ujs/commit/96e084b37bedfb7fe6035327f...
That is the latest prior to my commits on qhoxie/jquery-ujs, so it should apply cleanly. Did you see issues?
-
Quin Hoxie February 14th, 2010 @ 07:40 AM
- Assigned user set to “Yehuda Katz (wycats)”
I add a couple more similar fixes/improvements. Looks like Josh pulled in my first set of prototype changes so those are cared for.
-
-
Yehuda Katz (wycats) February 24th, 2010 @ 07:48 AM
- State changed from “new” to “resolved”
-
Jeremy Kemper October 15th, 2010 @ 11:01 PM
- Milestone set to “3.0.2”
- Importance changed from “” to “Low”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Quin Hoxie
Yehuda Katz (wycats)