#3979 [PATCH] Join conditions removed on habtm and has many through with conditions or STI - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#3979 ✓resolved

[PATCH] Join conditions removed on habtm and has many through with conditions or STI

Reported by David Genord II | February 17th, 2010 @ 04:38 PM

When utilizing a JoinDependency to load a habtm or has many through association that uses conditions and/or an STI target class that is not the base class, at least the join condition is lost producing incorrect results.

I have provided a patch that is split into 2 commits. The first commit alters the posts.yml and comments.yml fixtures and fixes the tests theses changes break. The second commit presents a new failing test case and the fix.

join_dependency_on_habtm_and_hmt.diff 11.3 KB

Comments and changes to this ticket

You flagged this item as spam.
David Genord II February 17th, 2010 @ 05:17 PM
Found another point of failure and updated the patch
- join_dependency_on_habtm_and_hmt2.diff 12.4 KB
You flagged this item as spam.
David Genord II February 24th, 2010 @ 10:15 PM
- Tag changed from “activerecord associations, 3.0pre, activerecord, rails3” to “activerecord associations, 3.0pre, activerecord, patch, rails3”
You flagged this item as spam.
Will Bryant May 26th, 2010 @ 05:17 AM
David, is this still an issue on master?
You flagged this item as spam.
David Genord II May 27th, 2010 @ 05:25 PM
Yes it is still an issue but the patch is going to change drastically. I should have it ready shortly.
You flagged this item as spam.
David Genord II May 27th, 2010 @ 07:22 PM
Here is an updated diff
- preserve_join_condition_and_conditions_on_hmt.diff 12.5 KB
Rohit Arondekar October 7th, 2010 @ 05:21 AM
- Tag changed from “activerecord associations, 3.0pre, activerecord, patch, rails3” to “3.0pre, activerecord, associations, patch, rails3”
[bulk edit]
Jon Leighton December 20th, 2010 @ 04:00 PM
- Assigned user set to “Aaron Patterson”
This is no longer an issue and so it can be closed.

I've run both of David's tests and they work. It's already covered by test_eager_with_has_many_through_join_model_with_conditions_on_top_level in eager_test.rb.
Jon Leighton December 20th, 2010 @ 07:49 PM
- State changed from “new” to “resolved”
- Importance changed from “” to “Low”