Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

backtrace_cleaner can't remove filters

#4079

Some of the filters in the backtrace cleaner interfere with various IDE's abilities to parse the backtrace to provide jump links. The remove_silencers! instance method does what it says on the box, but there's nothing similar for removing the filters. Simply adding

    module ActiveSupport
      class BacktraceCleaner
        def remove_filters!
          @filters = []
        end
      end
    end

is enough.

Reported by Doug Alcorn · March 1st, 2010 @ 08:02 PM

State: resolved
Milestone: 3.0.2
Assigned to: José Valim José Valim
Importance: Low

Activity

  1. José Valim
    José Valim
    • Milestone cleared.
    • State changed from new to incomplete
    • Assigned user set to José Valim

    Can you please provide a patch using the information provided here:

    http://rails.lighthouseapp.com/projects/8994/sending-patches

    Please include some tests as well. Thanks!

    March 27th, 2010 @ 10:35 AM

  2. Doug Alcorn
    Doug Alcorn
    • Tag set to patch

    Here's a simple patch (with test!) adding the remove_filters!

    March 27th, 2010 @ 04:54 PM

  3. Repository
    Repository
    • State changed from incomplete to resolved

    (from [dc974306301809f4e184f518261f5baae2c909eb]) ActiveSupport::BacktraceCleaner#remove_filters! allows for completely untouched backtrace [#4079 backtrace_cleaner can't remove filters state:resolved]

    Signed-off-by: José Valim jose.valim@gmail.com
    http://github.com/rails/rails/commit/dc974306301809f4e184f518261f5b...

    April 10th, 2010 @ 01:06 PM

  4. Jeremy Kemper
    Jeremy Kemper
    • Milestone set to 3.0.2
    • Importance changed from to Low

    October 15th, 2010 @ 11:01 PM