This project is archived and is in readonly mode.
#as_json returning self?
Reported by Brian Lopez | April 12th, 2010 @ 10:55 PM
I may have completely misunderstood what the #as_json method is for, but it was my assumption that it's supposed to return a JSON-mappable version of the object.
Meaning, it should return a String, Fixnum, TrueClass, FalseClass, NilClass, Array or Hash. In literally every example of it's use those are the types that are returned - which makes perfect sense.
But classes like Regexp and BigDecimal return self? If a JSON library checks to see if the object responds to #as_json, and calls it if so, it'll infinitely loop.
Should BigDecimal return to_f? And Regexp to_s?
Comments and changes to this ticket
-
Santiago Pastorino April 12th, 2010 @ 11:16 PM
- State changed from “new” to “duplicate”
Duplicates #4375
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Brian Lopez
Santiago Pastorino