This project is archived and is in readonly mode.

Using finder_sql on has_many association will ignore :dependent option

#4560

Regard the following code:

class Parent < AR::Base
  has_many :children,
     :finder_sql => "SELECT * from children WHERE mother_id = #{id} OR father_id = #{id}',
     :dependent => :destroy  # or :delete_all
end

class Child < AR::Base
end

When removing a parent, I would expect the associated children to be deleted also. But they are not.

This needs to be either documented in the Rails documentation, or implemented.

Thank you ;)

Reported by Jens · May 9th, 2010 @ 08:40 AM

Activity

Matt Jones
:dependent => :delete_all is unlikely to be implemented for this case, as it's not practical to try to generate the necessary SQL from :finder_sql.

On the other hand, I can't see any reason why :dependent => :destroy shouldn't be working exactly as designed - the code in configure_dependency_for_has_many is simply loading all the records and calling destroy on them. Can you provide a test case where :destroy fails to work?

May 9th, 2010 @ 06:19 PM
Santiago Pastorino
- State changed from new to open
- Importance changed from to Low
This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

February 2nd, 2011 @ 05:02 PM
Santiago Pastorino
- State changed from open to stale
February 2nd, 2011 @ 05:02 PM
bingbing
gucci watches

March 26th, 2011 @ 01:31 AM