#4610 Added missing require, we are using here the bind method defined on active_support/core_ext/proc - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#4610 ✓committed

Added missing require, we are using here the bind method defined on active_support/core_ext/proc

Reported by Santiago Pastorino | May 16th, 2010 @ 03:06 AM | in 3.0.2

......E......................................E......
Finished in 2.201572 seconds.

  1) Error:
test_being_able_to_put_proc's_into_the_defaults_hash_and_they_get_evaluated_on_mail_sending(BaseTest):
NoMethodError: undefined method `bind' for #
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionmailer/lib/action_mailer/base.rb:571:in `mail'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionmailer/lib/action_mailer/base.rb:570:in `merge'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionmailer/lib/action_mailer/base.rb:570:in `mail'
    base_test.rb:123:in `welcome'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/abstract_controller/base.rb:144:in `send_action'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/abstract_controller/base.rb:144:in `process_action'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/abstract_controller/base.rb:113:in `process'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/abstract_controller/rendering.rb:39:in `process'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionmailer/lib/action_mailer/old_api.rb:75:in `process'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionmailer/lib/action_mailer/base.rb:416:in `process'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionmailer/lib/action_mailer/base.rb:411:in `initialize'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionmailer/lib/action_mailer/base.rb:395:in `new'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionmailer/lib/action_mailer/base.rb:395:in `method_missing'
    base_test.rb:582:in `test_being_able_to_put_proc's_into_the_defaults_hash_and_they_get_evaluated_on_mail_sending'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in `__send__'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in `run'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/callbacks.rb:408:in `_run_setup_callbacks'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:65:in `run'

  2) Error:
test_we_can_call_other_defined_methods_on_the_class_as_needed(BaseTest):
NoMethodError: undefined method `bind' for #
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionmailer/lib/action_mailer/base.rb:571:in `mail'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionmailer/lib/action_mailer/base.rb:570:in `merge'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionmailer/lib/action_mailer/base.rb:570:in `mail'
    base_test.rb:123:in `welcome'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/abstract_controller/base.rb:144:in `send_action'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/abstract_controller/base.rb:144:in `process_action'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/abstract_controller/base.rb:113:in `process'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/abstract_controller/rendering.rb:39:in `process'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionmailer/lib/action_mailer/old_api.rb:75:in `process'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionmailer/lib/action_mailer/base.rb:416:in `process'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionmailer/lib/action_mailer/base.rb:411:in `initialize'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionmailer/lib/action_mailer/base.rb:395:in `new'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionmailer/lib/action_mailer/base.rb:395:in `method_missing'
    base_test.rb:590:in `test_we_can_call_other_defined_methods_on_the_class_as_needed'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in `__send__'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in `run'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/callbacks.rb:408:in `_run_setup_callbacks'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:65:in `run'

52 tests, 155 assertions, 0 failures, 2 errors

Comments and changes to this ticket

Santiago Pastorino May 16th, 2010 @ 03:08 AM
- State changed from “new” to “open”
Patch for the failing tets
- am_tests.patch 798 Bytes
Santiago Pastorino May 16th, 2010 @ 06:16 AM
- Tag changed from “actionmailer, bugmash, tests” to “actionmailer, bugmash, bugmash-review, patch, tests”
Rizwan Reza May 16th, 2010 @ 09:32 AM
- Tag changed from “actionmailer, bugmash, bugmash-review, patch, tests” to “actionmailer, bugmash, patch, tests”
Let's test this before core's review.
José Valim May 16th, 2010 @ 02:00 PM
Good catch Pastorino! But the require should rather be in the action_mailer/base.rb, no?
Santiago Pastorino May 16th, 2010 @ 02:32 PM
Absolutely right, like always José ;)
- am.patch 968 Bytes
You flagged this item as spam.
Hussein Morsy May 16th, 2010 @ 02:50 PM
+1 verified.
Repository May 16th, 2010 @ 03:16 PM
- State changed from “open” to “committed”
(from [fa5f93698d33469249d9ca5b122002a617ad39e6]) Added missing require, we are using bind method defined on active_support/core_ext/proc

[#4610 state:committed]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/fa5f93698d33469249d9ca5b122002...
You flagged this item as spam.
Anil Wadghule May 16th, 2010 @ 03:26 PM
- Tag changed from “actionmailer, bugmash, patch, tests” to “actionmailer, patch, tests”
Jeremy Kemper October 15th, 2010 @ 11:01 PM
- Milestone set to “3.0.2”
- Importance changed from “” to “Low”
[bulk edit]