Rails Ruby on Rails

Comments and changes to this ticket

• You flagged this item as spam.
  

  gucki May 16th, 2010 @ 01:24 PM

  Here's a little optimized version. Better performance and only invoke if a single record is passed to polymorphic_path. This improve backwards compatibility even more :)

    unless record_or_hash_or_array.is_a?(Array)
      namespaces = record.class.name.split('::')
      if namespaces.size>1
        data = args.first
        namespaces.pop
        namespaces.reverse.each do |namespace|
          data = data.send(namespace.downcase)
          args.unshift data
        end
      end
    end
  

• 

  Andrew White June 7th, 2010 @ 09:09 AM

  Have you tried overriding model_name in the member and job models? e.g:

  class Team::Member < ActiveRecord::Base
    def self.model_name
      ActiveSupport::ModelName.new("Member")
    end
  end
  

  After doing this app.polymorphic_path([t, m]) should work.

• 

  José Valim June 7th, 2010 @ 09:32 AM

  • State changed from “new” to “invalid”

  Good solution! But, as you said, this is specific to your application so it does not make sense in Rails itself.

• You flagged this item as spam.
  

  gucki June 7th, 2010 @ 09:39 AM

  Thanks Andrew. But this is only a solution to the error but not for the problem that the whole thing is still not DRY.

  Specifying a path with app.polymorphic_path([t, m]) seems not DRY to me. One should only have to specify app.polymorphic_path(m) as the parent (here team) could be resolved from the namespace, as my code above does.

• 

  Andrew White June 7th, 2010 @ 10:19 AM

  Gucki, your solution will only work where the associations are given the default names. I'd argue that trying to tie knowledge of the model into the router is likely to end up making things worse. For example I use the model_name override method to have a generic controller for some STI models - your patch would break that by using the full class name and not the STI base class. Also I have STI models inside a collection module (e.g. Page::Components::MenuComponent) which would also break with your patch.