Comments and changes to this ticket

• 

  Jeremy Kemper June 22nd, 2008 @ 12:59 AM

  • Milestone set to “2.1.1”
  • Assigned user set to “Jeremy Kemper”
  • State changed from “new” to “open”

  Talked about this in #rails-contrib:

  • should raise ActiveRecordError instead of RuntimeError, and add a test for rename_column with a column that does not exist
  • and test that a column with DEFAULT NULL is preserved also

• You flagged this item as spam.
  

  Diego Algorta June 22nd, 2008 @ 03:38 AM

  Here's a new version of the patch. This one adds a new test for renaming nonexistent columns and raises ActiveRecordError in that case.

  I realized the "unless default.nil?" was unnecessary so the extra test for that is unnecessary too. Because DEFAULT NULL is the default anyway. So using :default => nil is the same as not using it.

  I squashed the changes into only one commit.

• You flagged this item as spam.
  

  Diego Algorta June 22nd, 2008 @ 03:42 AM

  I mean... I DID add the test for the DEFAULT NULL case... but the current and the new code already passed that. So I thought it was unnecessary.

• You flagged this item as spam.
  

  Diego Algorta June 22nd, 2008 @ 03:56 AM

  same patch, corrected my name and email.

  • preserve_defaults_on_mysql_column_renames-2.diff 3.3 KB
• 

  Repository June 22nd, 2008 @ 11:23 PM

  • State changed from “open” to “resolved”

  (from [2e1b56c93745bf0513e449e95830edd390abfaf2]) MySQL: rename_column preserves default values. [#466 state:resolved]

  http://github.com/rails/rails/co...

• 

  Repository June 22nd, 2008 @ 11:23 PM

  (from [9855d0b0800d92626aa19606628ed77042491984]) MySQL: rename_column preserves default values. [#466 state:resolved]

  http://github.com/rails/rails/co...

• 

  Rick October 31st, 2008 @ 03:38 AM

  • Assigned user cleared.
  • Milestone cleared.
  • Tag set to “2.1, activerecord, bug, edge, patch, tested”

  Testing...

• You flagged this item as spam.
  

  klkk May 23rd, 2011 @ 02:59 AM

  • Importance changed from “” to “”

  www.louisvuittonwarehouse.com