Router in Rails 3 pluralizes collection named routes twice

Hi Santiago.
I don't know what you mean.
I already have an initializer with the inflections for the language of my app.

ActiveSupport::Inflector.inflections do |inflect|
  inflect.plural( /$/, 'es')
  inflect.plural(/z$/i, 'ces')
  inflect.plural(/([aeiou])$/i, '\1s')

  inflect.singular(/s$/i, '')
  inflect.singular(/es$/i, '')
  inflect.singular(/ces$/i, 'z')
  inflect.singular(/([tj])es$/i, '\1e')

end

And it works great, for all the application, except in the routes, and only when I use the new router syntax.
Also works well when I use the old router syntax, and this make me think of a problem.

Juanma Cervera

If you compare the deprecated mapper to the new mapper then you can see there's an extra call to pluralize which is causing the problem.

My Spanish isn't up to the task but if you adjust the first inflect.plural to not match words ending 'es' then that should fix your problem as invoking pluralize on English plural words doesn't double pluralize them.

I'm facing the same error, using a fresh rails project using latest beta4 and no custom inflections. Please see here:
#4857 Router in Rails 3 doesn't use inflections properly *really*

My Spanish isn't up to the task but if you adjust the first inflect.plural to not match words ending 'es' then that should fix your problem

Hello, Andrew.

I'm spanish as well and am using similar inflection rules, so I've got the same problem.

Unfortunately, your suggestion isn't free of troubles. In spanish, there are words that are singular and end in "s", like "res", whose plural is "reses" (same rule as any other word ending in a consonant).

I know I can add irregular plurals, but then I guess that if we use them for regular plurals we miss the point of defining expressions about how to make plurals.

This bug is mark as "invalid", but I don't think it should be. "wontfix" maybe, but Rails is supposed to have rules such as "singular form for member path and plural form for collection path", and here it is creating "singular form for member path and plural of the plural for collection path", because of the extra call to pluralize that you mention.

Thanks!

Apparently it also happens with english words, even if I don't use any inflections.

The plural of "taxi" is "taxis", but the plural of "taxis" is "taxes". So if I generate a "taxi" scaffold, "taxis_path" is not generated, but "taxes_path" is.

Unfortunately I haven't been able to come with a valid test case. Test cases for taxes are already there, and adding test cases for taxis ends up in failure, but I think it fails because of a conflict with the already defined routes for taxes.

I hope you take this as "trying to help" instead of "spamming on that thing nobody cares about", cause that's my intention ;). If you don't want to fix it, hey, it's your app, you have your priorities.

Hi, Andrew.

Didn't see your answer before, but in the meantime I've created a patch that makes the test pass and doesn't break any other tests (at least in action pack; couldn't test the whole suite):

http://gist.github.com/510293

What we need is a test where two words are likely to be used together and their pluralization overlaps similar to taxi(s) and tax(is|es) - it doesn't matter if they're Spanish.

I'm afraid I don't understand what you mean. Since I'm not sure we're talking about the same thing, I'll try to explain my problem.

The problem happens with almost any spanish word. The plural of "cliente" is "clientes". And grammar rules says that, if it existed, the plural of "clientes" would be "clienteses" (and the plural of "clienteses" would be "clienteseses", and so on), since words ending with a consonant make (usually) the plural with "-es",

And that's the original problem: applying spanish rules to the inflections made "clienteses_path" to be generated, instead of "clientes_path".

Hope it helps. Tell me if I'm understanding you wrong.

Thanks.

The patch is now applied in my fork:

http://github.com/javierv/rails/commit/41f3ccd2ca73f0029147ae613b7d...

Awesome! Thank you, Andrew.

It's ok if you figure as the author anyway. I wouldn't have come up with such a complete patch, after all.

(from [12f7f7a714cd485ba7c1b272ce1d6dbbcfae23e1]) Don't pluralize resource methods [#4704 Router in Rails 3 pluralizes collection named routes twice state:resolved]

Signed-off-by: Santiago Pastorino santiago@wyeworks.com
http://github.com/rails/rails/commit/12f7f7a714cd485ba7c1b272ce1d6d...