#4711 [PATCH] Rails 3: fields_for helper doesn't work with association proxy objects - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#4711 ✓wontfix

[PATCH] Rails 3: fields_for helper doesn't work with association proxy objects

Reported by Paul Rosania | May 27th, 2010 @ 01:14 AM

[Tested against latest Rails 3 edge.]

Mongoid uses association proxy objects. It overrides #nil? => false when the association is missing. However since it uses proxy objects, !!assocation is always true.

This patch changes the association nil test to call assocation.nil? rather than use implicit coercion of the variable.

fields_for_patch.diff 998 Bytes

Comments and changes to this ticket

Michael Koziarski May 29th, 2010 @ 02:38 AM
- State changed from “new” to “wontfix”
These proxy objects don't follow correct ruby semantics and I'm not entirely sure that we should take the performance hit to work around that bug. There are bound to be other places where we use this form and we're not going to fix all of them.
You flagged this item as spam.
bingbing March 26th, 2011 @ 02:15 AM
louis vuitton watches