This project is archived and is in readonly mode.

#4732 ✓stale
Serge Balyuk

[PATCH] ActionController::Dispatcher fix for handling of ApplicationController load errors

Reported by Serge Balyuk | May 30th, 2010 @ 04:59 PM | in 2.3.10

dispatcher.rb in dispatch contains if controller ||= (::ApplicationController rescue Base) line which is supposed to fall back to ActionController::Base in case of any error in loading of ApplicationController.

This form of rescue catches only RuntimeErrors, while any LoadError or SyntaxError (which are derived from Exception) pass this trap and ActionController::Base.call_with_exception doesn't get called. The first original exception then gets shadowed by such LoadError. In some cases these two exceptions can be different.

This bug in combination with #4731 can lead to completely misleading backtraces. In the case described in that ticket, the first exception was accurate (SyntaxError with file and line number), while subsequent try to load ApplicationController in dispatch was throwing "Expected app/helper/admin/some_helper.rb to define Admin::SomeHelper" while some_helper.rb was in perfect shape.

Please find proposed patch attached.

Thanks
Serge

Comments and changes to this ticket

  • Michael Koziarski

    Michael Koziarski June 4th, 2010 @ 05:15 AM

    • Milestone set to “2.3.9”
  • Jeremy Kemper

    Jeremy Kemper August 30th, 2010 @ 02:28 AM

    • Milestone changed from “2.3.9” to “2.3.10”
    • Importance changed from “” to “Low”
  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:49 PM

    • State changed from “new” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:49 PM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Attachments

Tags

Pages