This project is archived and is in readonly mode.

#4783 ✓stale
Tom Meier

Association Proxy missing block for send

Reported by Tom Meier | June 7th, 2010 @ 06:19 AM

Rails 2.3.5 --> edge

Currently unable to send on an association proxy as 'send' does not have a block.

For example:

tom = Author.create(:name => "Tom")
p = Post.create(:title => "New on Edge", :body => "Allow me to iterate via send on association proxy!", :author => tom)

counter = 0
tom.posts.send(:each){|post| counter += 1}

the total of this should be the same as

tom.posts.each{|post| counter+=1}

Currently this fails (silently), as send is overwritten for association proxy and the loop never kicks in for the each iterator.

Fix is to add block to send method on association_proxy.rb

def send(method, *args, &block)

    if proxy_respond_to?(method)
      super
    else
      load_target
      @target.send(method, *args, &block)
    end

end

Instead of what is currently there:

def send(method, *args)

    if proxy_respond_to?(method)
      super
    else
      load_target
      @target.send(method, *args)
    end

end

Diff attached with failing test in 2.3.5 + Edge (beta 3), and fix which causes test to pass.

Cheers,

Tom

Comments and changes to this ticket

  • Andrea Campi

    Andrea Campi October 16th, 2010 @ 11:48 PM

    • Tag changed from edge 2.3.5 associations association_proxy send to 2-3-stable, associations, association_proxy, edge
  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:28 PM

    • State changed from “new” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:28 PM

    • State changed from “open” to “stale”
  • bingbing

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Attachments

Pages