This project is archived and is in readonly mode.
AS::MB::Chars#slice! doesn't operate in-place; guide docs are out of date
-
Norman Clarke
- Tag changed from activesupport, docs, multibyte to activesupport, docs, multibyte, patch
Patch attached. Sorry for the extra-bold OMG SLICE!!!!! line above, not sure why that happened. :)
-
Santiago Pastorino
- Assigned user set to José Valim
- Milestone cleared.
- State changed from new to open
- Importance changed from to Low
-
José Valim
I cannot apply this patch anymore because the guide change. I would recommend you to fork github.com/lifo/docrails.git and do your docs change there (everyone has commit access) and provide the code change in one patch. :)
-
Norman Clarke
No problem. Here's the commit without the doc updates, and rebased against the current master.
-
Repository
- State changed from open to resolved
(from [6f83a57ac7bf77565380b26b506972cfe751b717]) Improve bang method defs, make slice! operate in-place. [#5028 AS::MB::Chars#slice! doesn't operate in-place; guide docs are out of date state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/6f83a57ac7bf77565380b26b506972...
