This project is archived and is in readonly mode.
FormBuilder date helpers ignore html_options
Reported by Pascal Ehlert | June 28th, 2008 @ 04:15 PM | in 2.x
It turned out that the form builder (f.) helpers of date_select, datetime_select and time_select ignore the html_options you pass to it.
They do work for the normal helper from DateHelpers class however, the problem is that the html_options hash simply gets not passed through to them in their form builder definitions.
Some Rails developers apparently need more coffee. ;-)
Comments and changes to this ticket
-
Pratik June 28th, 2008 @ 06:59 PM
- State changed from “new” to “incomplete”
Hey Pascal,
Could you please add tests as well ?
Thanks.
-
Pascal Ehlert June 28th, 2008 @ 07:43 PM
- Tag changed from “2.1, actionpack, forms, helper, patch” to “2.1, actionpack, forms, helper, patch, tests”
Sorry for not including them in the first patch, I was a bit in a hurry earlier.
I have attached an updated version with tests. Hope this makes it into trunk soon.
-
Pratik June 28th, 2008 @ 08:24 PM
- State changed from “incomplete” to “open”
-
Repository June 29th, 2008 @ 12:51 AM
(from [029a7455846cde2654958358a6fe354f236ade35]) Ensure FormBuilder date helpers respects html_options. [#506 state:resolved] [Pascal Ehlert]
Signed-off-by: Pratik Naik
-
Repository June 29th, 2008 @ 12:52 AM
(from [b416c6880bba538799513f4afd4125a0be8c2fb5]) Ensure FormBuilder date helpers respects html_options. [#506 state:resolved] [Pascal Ehlert]
Signed-off-by: Pratik Naik
Conflicts:
actionpack/test/template/date_helper_test.rb
-
Pascal Ehlert July 2nd, 2008 @ 10:43 AM
Thanks for fixing, Pratik!
Shouldn't this ticket be closed now?
-
Pratik July 2nd, 2008 @ 12:50 PM
- State changed from “open” to “resolved”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Pascal Ehlert
Pratik