This project is archived and is in readonly mode.
[PATCH] Warning about method redefined in active_model
Reported by Łukasz Strzałkowski | July 8th, 2010 @ 08:39 PM
When runnign test suite there are warnings:
/Users/strzalek/projects/ruby/rails_source/activemodel/lib/active_model/observing.rb:161: warning: method redefined; discarding old observed_classes
/Users/strzalek/projects/ruby/rails_source/activemodel/lib/active_model/observing.rb:161: warning: previous definition of observed_classes was here
/Users/strzalek/projects/ruby/rails_source/activemodel/lib/active_model/observing.rb:161: warning: method redefined; discarding old observed_classes
/Users/strzalek/projects/ruby/rails_source/activemodel/lib/active_model/observing.rb:161: warning: previous definition of observed_classes was here
/Users/strzalek/projects/ruby/rails_source/activemodel/lib/active_model/observing.rb:161: warning: method redefined; discarding old observed_classes
/Users/strzalek/projects/ruby/rails_source/activemodel/lib/active_model/observing.rb:161: warning: previous definition of observed_classes was here
/Users/strzalek/projects/ruby/rails_source/activemodel/lib/active_model/observing.rb:161: warning: method redefined; discarding old observed_classes
/Users/strzalek/projects/ruby/rails_source/activemodel/lib/active_model/observing.rb:161: warning: previous definition of observed_classes was here
There are 2 ways to avoid this warning. First is to alias old method, second is to remove it. As it isn't no longer used I think it can be removed.
Patch attached.
Comments and changes to this ticket
-
Repository July 8th, 2010 @ 10:03 PM
- State changed from “new” to “resolved”
(from [4a26a292a0708df595662444e8c738ee1520ec57]) Removing method before redefining it. It was causing warnings. [#5072 state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/4a26a292a0708df595662444e8c738...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
- Nobody is watching this ticket.
Attachments
Tags
Referenced by
-
5072
[PATCH] Warning about method redefined in active_model
(from [4a26a292a0708df595662444e8c738ee1520ec57])
Removin...