#5160 [Patch] Ignore asset host for relative uri with host - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#5160 ✓resolved

[Patch] Ignore asset host for relative uri with host

Reported by valodzka | July 20th, 2010 @ 03:14 PM

According to URI rfc this is relative uri with host but without scheme:

//example.com/test

Currently rails handles such uri incorrectly when assets host set. It adds asset host to such urls, and that is incorrect,

This commit (in attach) fixes problem.

assets_uri.diff 2.2 KB

Comments and changes to this ticket

You flagged this item as spam.
valodzka July 21st, 2010 @ 07:08 PM
- Title changed from “Ignore asset host for relative uri with host” to “[Patch] Ignore asset host for relative uri with host”
- Assigned user set to “Pratik”
You flagged this item as spam.
Andrea Campi October 17th, 2010 @ 12:04 AM
- Tag changed from “absolutepath, asset_host, patch, url” to “absolutepath, asset_host, patch, rails3, url”
+1 looks good and tests pass
Santiago Pastorino February 2nd, 2011 @ 04:29 PM
- State changed from “new” to “open”
This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
Santiago Pastorino February 2nd, 2011 @ 04:29 PM
- State changed from “open” to “stale”
You flagged this item as spam.
sergey.kojin February 20th, 2011 @ 10:51 AM
Problem is still here, I'm get it when tried to use jquery from google CDN.
I'm rewrite patch for rails3 edge.
- protocol_relative_url.diff 2.1 KB
You flagged this item as spam.
sergey.kojin February 20th, 2011 @ 10:53 AM
- State changed from “stale” to “open”
Here is patch with tests only, to see that problem is really here. [state:open]
- protocol_relative_url_tests.diff 1.5 KB
You flagged this item as spam.
sergey.kojin February 22nd, 2011 @ 04:44 PM
- Assigned user changed from “Pratik” to “José Valim”
You flagged this item as spam.
sergey.kojin April 26th, 2011 @ 08:58 PM
fixed https://github.com/rails/rails/commit/4ce14fb0809ea8d636be0a1790fa3...
José Valim April 26th, 2011 @ 08:59 PM
- State changed from “open” to “resolved”
- Importance changed from “” to “Low”