This project is archived and is in readonly mode.
Id and parameter in path is not properly escaped for ActiveResource
Reported by Josef Reidinger | July 21st, 2010 @ 03:46 PM | in 3.0.2
Hi,
we use in project as id sometime also unique strings and it can
contain space. Rails doesn't work in that case and doesn't escape
it.
I attach fix which add escaping also for parameters in path. (patch
is again 2.3.8 if you find it suitable I can do it also for
master)
Comments and changes to this ticket
-
Josef Reidinger July 21st, 2010 @ 03:50 PM
- Assigned user set to “Rick”
-
José Valim July 21st, 2010 @ 09:11 PM
- Milestone cleared.
- State changed from “new” to “open”
- Assigned user changed from “Rick” to “José Valim”
- Importance changed from “” to “Low”
Great! Please also do provide a patch for master!
-
Josef Reidinger July 22nd, 2010 @ 07:44 AM
- Assigned user changed from “José Valim” to “Rick”
Here is patch against master. Also please note that in patch for 2.3 branch is unnecessary changes to require in test file( I again run into issue with shoulda and mocha and it is easy quick workaround - http://blog.anlek.com/2009/10/uninitialized-constant-test-unit-test...)
thanks -
-
Josef Reidinger July 22nd, 2010 @ 07:46 AM
- Assigned user changed from “Rick” to “José Valim”
-
José Valim July 26th, 2010 @ 06:43 PM
- State changed from “open” to “resolved”
Applied:
http://github.com/rails/rails/commit/0e969bdaf8ff2e3384350687aa0b58...
Unfortunately I pointed to the wrong ticket in the message. :P
-
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Jeremy Kemper
José Valim
Josef Reidinger
Rick
Attachments
Tags
Referenced by
-
5153
remove unused require from association test
i am trying to test after rebase. but the arel fork for r...