#5311 ActiveModel::Validations uses Hash#except, but does not require it from ActiveSupport - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#5311 ✓resolved

ActiveModel::Validations uses Hash#except, but does not require it from ActiveSupport

Reported by Greg Campbell | August 5th, 2010 @ 08:20 PM

Quick example:


    require 'active_model'

    class Model
      include ActiveModel::Validations
      attr_accessor :name
      validates_presence_of :name
    end

    Model.new.valid? # raises NoMethodError: undefined method `except' for {}:Hash

This was masked in the tests because the file is required elsewhere.
Patch (a simple one, of course) will be attached shortly.

Comments and changes to this ticket

You flagged this item as spam.
Greg Campbell August 5th, 2010 @ 08:22 PM
- Tag set to “patch activemodel”
- validations_require.diff 1.7 KB
You flagged this item as spam.
Greg Campbell August 5th, 2010 @ 08:23 PM
- Tag changed from “patch activemodel” to “activemodel, patch”
David Trasbo August 6th, 2010 @ 07:54 AM
- Assigned user set to “José Valim”
This patch seems good. Assigning it to José - maybe he'll apply it.
Repository August 14th, 2010 @ 12:23 PM
(from [1577eafe77ce2a1aed3049dde34eac721b8e5aa5]) Add missing ActiveModel::Validations require

[#5311 state: resolved]

ActiveModel::Validations uses Hash#except, but does not require it from
ActiveSupport. (This wasn't showing up in the tests, because it was
required in the helper, and was also required in
ActiveModel::Serialization).

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/1577eafe77ce2a1aed3049dde34eac...
Rohit Arondekar August 14th, 2010 @ 03:22 PM
- State changed from “new” to “resolved”
- Importance changed from “” to “Low”