This project is archived and is in readonly mode.
Incorrect SQL from find with :limit and function call in :order
Reported by Frank Richter | August 12th, 2010 @ 10:33 AM
Given two associated Models one can do:
ModelA.find(:all, :include => :model_b, :order =>
'some_field, another_field', :limit => 10)
This works fine. But if we use a function call with comma
separated parameter list in the order-by clause,
as in
ModelA.find(:all, :include => :model_b, :order => 'substr(some_field, 3, 5)', :limit => 10)
we get a PGError (Syntaxerror). The generated SQL is:
SELECT * FROM (SELECT DISTINCT ON ("model_a".id) "model_a".id, substr(model_b.some_field AS alias_0, 3 AS alias_1, 5) AS alias_2 FROM "model_a" LEFT OUTER JOIN "model_b" ON "model_b"."model_a_id" = "model_a"."id") AS id_list ORDER BY id_list.alias_0 , id_list.alias_1 , id_list.alias_2 LIMIT 2
Looks like rails generated a field list from the order by clause
by separating the clause on commas, regardless
for what purpose they are there.
Comments and changes to this ticket
-
Frank Richter August 12th, 2010 @ 10:36 AM
- Tag set to “2.3.8, 3.0.0.rc”
Did function properly until rails-2.3.5, broke in 2.3.8 and 3.0-rc
-
Daniel Schreiber September 7th, 2010 @ 11:09 AM
This Bug only appears when using PostgreSQL. PostgreSQL expects all columns appearing in the ORDER BY fragment to appear after the DISTINCT ON(column) fragment. The Bug also only appears when ModelA.has_mamy :model_by
The attached patch splits the order by fragment only at commas which are neither included in a string nor enclosed in braces. The patch is for 2.3
-
Daniel Schreiber September 7th, 2010 @ 12:55 PM
- no changes were found...
-
Daniel Schreiber September 7th, 2010 @ 12:56 PM
- Tag changed from “2.3.8, 3.0.0.rc” to “2.3.8, 3.0.0.rc, patch”
-
Santiago Pastorino February 2nd, 2011 @ 04:32 PM
- State changed from “new” to “open”
- Tag changed from “2.3.8, 3.0.0.rc, patch” to “238, 300rc, patch”
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino February 2nd, 2011 @ 04:32 PM
- State changed from “open” to “stale”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Daniel Schreiber