This project is archived and is in readonly mode.
split out migration logic in generators
Reported by jack dempsey (jackdempsey) | August 17th, 2010 @ 04:03 AM
Currently the ActiveRecord::Generators::Base class inherits from NamedBase. This means that any generator that wants to make use of a method such as migration_template needs to pass in a NAME to the generator. This so far has always fit the current generator usage well, but for others in the future it may be inconvenient.
This simple patch pulls the logic out into a module that another generator could easily include and use to build a non NamedBase subclass that creates a migration.
We could also have ActiveRecord::Generators::Base inherit from Base instead, but I imagine that would lead to a lot of other unnecessary and perhaps complex changes.
Comments and changes to this ticket
-
Repository September 1st, 2010 @ 09:15 AM
- State changed from new to resolved
(from [c25c81e7c9656dee2b5ac9d490784df44e8e23f9]) split out active_record migration logic so others can easily reuse [#5389 state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/c25c81e7c9656dee2b5ac9d490784d... -
Repository September 1st, 2010 @ 09:15 AM
(from [a79e985923389863cae0f4a98538096e3723e010]) split out active_record migration logic so others can easily reuse [#5389 state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/a79e985923389863cae0f4a9853809... -
Andrea Campi October 11th, 2010 @ 07:18 AM
- Tag changed from patch activerecord, enhancement to activerecord, enhancement, patch
bulk tags cleanup
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Attachments
Tags
Referenced by
- 5389 split out migration logic in generators (from [c25c81e7c9656dee2b5ac9d490784df44e8e23f9]) split o...
- 5389 split out migration logic in generators (from [a79e985923389863cae0f4a98538096e3723e010]) split o...