This project is archived and is in readonly mode.
[PATCH] Load path for 1.9.2 in spec_helper.rb. No map method for string in 1.9.2
Reported by Marjan Krekoten' | August 25th, 2010 @ 08:04 PM
Hi, I attached patch which fixes load path in spec_helper.rb for
ruby 1.9.2.
Also it contains fix for missing String#map in ruby 1.9.2 in
Arel::Where#initializer.
Comments and changes to this ticket
-
Marjan Krekoten' August 25th, 2010 @ 08:07 PM
- Tag changed from “patch arel 1.9.2” to “1.9.2, arel, patch”
-
Aaron Patterson August 25th, 2010 @ 09:58 PM
- Importance changed from “” to “Low”
Please split this to two patches. Also, can you add the load path for "rake spec" rather than the spec helper?
Thanks!
-
-
Marjan Krekoten' August 26th, 2010 @ 10:51 AM
Sorry for taking too long.
Splited and fixed as you said :) -
Aaron Patterson August 28th, 2010 @ 08:09 AM
- State changed from “new” to “incomplete”
Hi Marjan, I've applied the 001 patch. Can you provide a test for the second patch? If I don't have a test, I'm afraid this fix will get regressed some day.
Thanks!
-
Marjan Krekoten' August 28th, 2010 @ 10:34 AM
Well, test is already exists in source. Under ruby 1.9.2-p0 engines/sql/unit/relations/where_spec.rb:43 fails with
NoMethodError in 'Arel::Where#to_sql when given a string passes the string through to the where clause' undefined method
map' for "asdf":StringSo that patch fixes this issue.
-
Aaron Patterson August 29th, 2010 @ 01:58 AM
- State changed from “incomplete” to “committed”
Doh! Sorry, I must be not thinking straight today. I've applied your patch. :-)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Aaron Patterson
Jeremy Kemper