This project is archived and is in readonly mode.
cannot pass {:class_name => symbol} in belongs_to in AR 2.3.8 with Ruby 1.9.2
Reported by Suraj N. Kurapati | August 25th, 2010 @ 09:48 PM
With Ruby 1.9.2 and ActiveRecord 2.3.8, I get a "TypeError: can't convert Symbol into String" when trying to resolve a belongs_to association, whose :class_name was passed a symbol:
class Publication < ActiveRecord::Base
belongs_to :owner, :class_name => :User, :foreign_key => :user_id
end
If I change the :User symbol to a string, there is no error:
class Publication < ActiveRecord::Base
belongs_to :owner, :class_name => "User", :foreign_key => :user_id
end
The error occurs at lib/active_record/base.rb:2232 because a symbol is passed to eval() instead of a String. This used to work just fine in Ruby 1.9.1 (by accident!) because of a bug http://redmine.ruby-lang.org/issues/show/2699 that is now fixed in Ruby 1.9.2.
My suggestion to fix the problem: make sure you run #to_s on the code being passed to eval(). IMHO this is generally a good thing to do, everywhere in Rails!
Thanks for your consideration.
Comments and changes to this ticket
-
Suraj N. Kurapati August 25th, 2010 @ 09:52 PM
- Tag changed from “active record, 1.9.2, string” to “active record, ruby 1.9.2, 2.3.8”
-
Suraj N. Kurapati August 25th, 2010 @ 10:27 PM
Here is an ugly monkey-patch that makes Ruby 1.9.2 behave like Ruby 1.9.1 with respect to implicit Symbol to String conversion:
class Symbol alias to_str to_s endThis ought to sustain my apps for now, until Rails 2.3.9 comes out soon with proper Ruby 1.9.2 support. Cheers.
-
Santiago Pastorino February 2nd, 2011 @ 04:33 PM
- State changed from “new” to “open”
- Tag changed from “active record, ruby 1.9.2, 2.3.8” to “active record, ruby 192, 238”
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino February 2nd, 2011 @ 04:33 PM
- State changed from “open” to “stale”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Suraj N. Kurapati