Fragment cache logging fails in 3.0 when fragment path contains printf chars, e.g. "%A"

Could you please provide the code that causes this issue?

Sure.

Example view code would look like this:

cache(:foo => "key with spaces") do
  ... render something ...
end

where #cache is presumably ActionView::Helpers::CacheHelper#cache

-Steve

Hmm, I think that the example given should have used "key:with:colons" rather than "key with spaces", since it looks like the problematic "%3A" was the result of url-escaping colons, not spaces -- sorry.

David: in the light of that mistake on my part, you might want to double-check that it's indeed working fine in Rails Master.

You're right, Steve! Was able to duplicate this issue on master:

Warmup:

Started GET "/people" for 127.0.0.1 at 2010-09-21 07:07:24 +0200
  Processing by PeopleController#index as HTML
Could not log "exist_fragment?.action_controller" event. ArgumentError: too few arguments
Could not log "write_fragment.action_controller" event. ArgumentError: too few arguments
Rendered people/index.html.erb within layouts/application (6.8ms)
Completed 200 OK in 10ms (Views: 9.8ms | ActiveRecord: 0.0ms)
cache: [GET /javascripts/prototype.js?1285045419] miss
cache: [GET /javascripts/effects.js?1285045419] miss
cache: [GET /javascripts/dragdrop.js?1285045419] miss
cache: [GET /javascripts/controls.js?1285045419] miss
cache: [GET /javascripts/rails.js?1285045419] miss
cache: [GET /javascripts/application.js?1285045419] miss
cache: [GET /favicon.ico] miss
cache: [GET /people] miss

After warmup:

Started GET "/people" for 127.0.0.1 at 2010-09-21 07:07:41 +0200
  Processing by PeopleController#index as HTML
Could not log "exist_fragment?.action_controller" event. ArgumentError: too few arguments
Could not log "read_fragment.action_controller" event. ArgumentError: too few arguments
Rendered people/index.html.erb within layouts/application (3.3ms)
Completed 200 OK in 7ms (Views: 6.2ms | ActiveRecord: 0.0ms)
cache: [GET /javascripts/dragdrop.js?1285045419] miss
cache: [GET /javascripts/effects.js?1285045419] miss
cache: [GET /javascripts/prototype.js?1285045419] miss
cache: [GET /javascripts/controls.js?1285045419] miss
cache: [GET /javascripts/rails.js?1285045419] miss
cache: [GET /javascripts/application.js?1285045419] miss

I might investigate how to solve this later today.

Marjon,

+1 for the fix, but -1 for the tests. I think you should make a separate test for percentage signs, to make sure people know they're there for a reason.

Ok, I'll fix tests soon. Thx for response.

Not sure if i should open a new ticket but with rails 3.0.7 i am getting the following error:

Could not log "read_fragment.action_controller" event. ArgumentError: malformed format string - %F

with the following code:

cache({:element => graph.cache_key, :lang => I18n.locale.to_s})

Graph is a normal model.

Indeed. I still get the same error messages too. They didn't ever go away for me with any particular Rails release, so I'm not convinced that the fix was complete.

私の中で、総合評価のとっても低いアバアバクロホリスタークロ銀座店。アバクロは大好きなんですけどね。一昨日の東京駅付近での打ち合わせの後、散歩がてら久々に行ってきました。そしたらビックリ！相変わらアバクロず、踊っているだけの店員さんとかもいましたが、