AbstractController#asset_path overrides routes helper

I can't reproduce this bug, I'm using the following:

• Rails Edge
• ruby 1.8.7 (2010-08-16 patchlevel 302) [i686-linux]

I had created an Asset scaffold and insert one record, next I had modified the index action to:

redirect_to asset_path(Asset.last)

And all it's ok, the action redirect to AssetsController#show.

I've tried this again in a fresh app on 3.0.0 and it still breaks. I can't test on Rails Edge, as apparently bundler can't resolve dependencies right now (something about activesupport ~> 3.0.0 and 3.1.0.beta).

Anyway, the relevant code hasn't changed in the meantime. Please have a look at abstract_controller/asset_paths.rb. There config_accessor defines a method #asset_path taking no arguments. AssetPaths is included in ActionController::Base which makes #asset_path (no-args variant) available in controllers.

I don't know why you don't get an exception where I do. Let's establish two things:

• The method #asset_path defined in AbstractController::AssetPaths is supposed to be available in controllers.
• If resources :assets is defined in routes.rb, #asset_path(asset) is supposed to be available in controllers (among other places).
• These two methods are in conflict with each other.

Do you agree?

Michael,

Yes, asset_path is supposed to be accessible in both Action Mailer and Action Controller.

I can see two ways around it. You could obviously rename it. Or: You could change the syntax of accessing asset_host and asset_path to be assets.host and assets.path.

I might look into making a patch for solution #2 - though I suspect it could get a bit complicated.

[bulk edit]

Automatic cleanup of spam.

[bulk edit]

[bulk edit]

[bulk edit]