This project is archived and is in readonly mode.
Removing $! from assert_select_test
Reported by Thiago Pradi | September 10th, 2010 @ 12:37 AM
Hi Guys,
This patch removes $! from assert_select_test, and uses normal exception syntax, which is more readable.
Comments and changes to this ticket
-
Rohit Arondekar September 10th, 2010 @ 01:54 PM
- Assigned user changed from “José Valim” to “Santiago Pastorino”
- Importance changed from “” to “Low”
+1
Assigning to Santiago because I think Jose is on holiday. :)
-
Thiago Pradi September 10th, 2010 @ 10:47 PM
Attached another patch to also remove it from ActiveRecord.
-
-
-
Santiago Pastorino September 11th, 2010 @ 03:36 AM
Can you join all the patches in one please i will apply them ;) thanks.
-
-
Repository September 19th, 2010 @ 08:19 PM
- State changed from “new” to “committed”
(from [3c9bf6e1dc3066e32651c955c6e237488115354d]) Exception handling more readable
[#5601 state:committed]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
http://github.com/rails/rails/commit/3c9bf6e1dc3066e32651c955c6e237... -
Repository September 19th, 2010 @ 08:19 PM
(from [ab59522ea1ded4dcf8fd6c6f94bbc7385e50c298]) Exception handling more readable
[#5601 state:committed]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
http://github.com/rails/rails/commit/ab59522ea1ded4dcf8fd6c6f94bbc7...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Jeremy Kemper
José Valim
Rohit Arondekar
Santiago Pastorino
Attachments
Tags
Referenced by
-
5601
Removing $! from assert_select_test
[#5601 state:committed]
-
5601
Removing $! from assert_select_test
[#5601 state:committed]