This project is archived and is in readonly mode.
[PATCH] search_field form helper leaves the :object key in html attributes
-
Aditya Sanghi
- Tag changed from formhelper, rails3.0.0 to 3.0.0, formhelper, rails3.0.0
-
Aditya Sanghi
- Tag changed from 3.0.0, formhelper, rails3.0.0 to 3.0.0, formhelper
-
Aditya Sanghi
- Assigned user set to José Valim
- Tag changed from 3.0.0, formhelper to 3.0.0, actionview, formhelper
This time i read the contributor's guide and now i'm providing the patch as well.
-
Aditya Sanghi
- Title changed from search_field form helper leaves leaves the :object key in options invalidating the form to [PATCH] search_field form helper leaves leaves the :object key in options invalidating the form
-
Aditya Sanghi
- Tag changed from 3.0.0, actionview, formhelper to 3.x, actionview, formhelper
-
Aditya Sanghi
- Title changed from [PATCH] search_field form helper leaves leaves the :object key in options invalidating the form to [PATCH] search_field form helper leaves the :object key in html attributes
-
Rohit Arondekar
- State changed from new to incomplete
- Importance changed from to Low
You need to add a test so that the code is not removed later on.
-
Aditya Sanghi
Alrighty then .. here's another patch with a test included as well. Was real tricky to get the test in place since the problem only surface when used in the form_for context. Not sure if the test is in the right location right now but that's the best i could think of.
-
Aditya Sanghi
- Tag changed from 3.x, actionview, formhelper to 3.x, actionview, formhelper, state:new
-
Aditya Sanghi
- Tag changed from 3.x, actionview, formhelper, state:new to 3.x, actionview, formhelper
-
Repository
- State changed from incomplete to resolved
(from [8d1df887d32643f0aee2d71f7216ec98fdfe4fdb]) Fixing search_field to remove object attribute from options hash [#5730 [PATCH] search_field form helper leaves the :object key in html attributes state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/8d1df887d32643f0aee2d71f7216ec... -
Repository
(from [3569bde28e47d351065208266a5c4a3fc7f3f8ae]) Fixing search_field to remove object attribute from options hash [#5730 [PATCH] search_field form helper leaves the :object key in html attributes state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/3569bde28e47d351065208266a5c4a...
