Rails Ruby on Rails

Comments and changes to this ticket

• 

  David Trasbo October 10th, 2010 @ 04:22 PM

  • State changed from “new” to “incomplete”
  • Importance changed from “” to “Low”

  Confirmed on Rails edge:

  $ script/rails g model update 
  ...
  $ script/rails g model comment update:references body:string
  ...
  $ rake db:migrate
  ...
  

  Models:

  class Update < ActiveRecord::Base
    has_many :comments
  end
  
  class Comment < ActiveRecord::Base
    belongs_to :update
  end
  

  $ script/rails c
  Loading development environment (Rails 3.1.0.beta)
  ruby-1.9.2-p0 > u = Update.create
   => #<Update id: 1, created_at: "2010-10-10 15:21:19", updated_at: "2010-10-10 15:21:19"> 
  ruby-1.9.2-p0 > u.comments << Comment.new(:body => 'Foo.')
   => [#<Comment id: 1, update_id: 1, body: "Foo.", created_at: "2010-10-10 15:21:38", updated_at: "2010-10-10 15:21:38">] 
  ruby-1.9.2-p0 > Comment.first.update_attribute(:body, 'Bar.')
   => true 
  ruby-1.9.2-p0 > Comment.first
   => #<Comment id: 1, update_id: 1, body: "Foo.", created_at: "2010-10-10 15:21:38", updated_at: "2010-10-10 15:21:38">
  

  Please provide a patch (https://rails.lighthouseapp.com/projects/8994/sending-patches) with a fix and/or a failing test.

• You flagged this item as spam.
  

  Andrea Campi October 10th, 2010 @ 11:11 PM

  • Tag set to “activerecord, patch”

  It's not very surprising that your use case doesn't work: #update is a reserved word in ActiveRecord (it's not in the public API, but still documented).
  In fact, it was already forbidden for regular attributes and methods, but not enforced for associations:

  script/rails g model comment update:string
  

  class Comment < ActiveRecord::Base
  end
  

  $ rails c
  ruby-1.9.2-p0 > Comment.new(:body => 'test', :update => 'test')
  ActiveRecord::DangerousAttributeError: update is defined by ActiveRecord
  

  With the attached patch you will get the same exception in your use case, too.

  Note that both in your original scenario and after my patch, you can work around this issue by naming your association differently:

  class Comment < ActiveRecord::Base
    belongs_to :an_update, :class_name => Update
  end
  

  • 5772-calling-a-model-update-leads-to-unexpected-behavior.diff 2 KB

• You flagged this item as spam.
  

  Erik van Eykelen October 11th, 2010 @ 02:27 PM

  I totally agree with avoiding reserved words, I simply overlooked the fact that it applies to model names too. I knew about Sessions though ;-)

  Your patch is great for folks creating a new model from scratch. However, for existing projects, e.g. ones migrated from 2.3.5 where a model called Update still worked, this issue is a bit of pitfall since update actions silently fail (e.g. update_attribute() returns true even though the actual UPDATE was not carried out).

  I guess update actions could trow an error in, but I realize that differentiating between method names like update() and associations like :update is possibly expensive.

• You flagged this item as spam.
  

  Andrea Campi October 12th, 2010 @ 06:44 AM

  In my patch, #instance_method_already_implemented? will raise an exception at load time, although that is not apparent from reading the patch.
  So in theory what you say should not happen.

  Do you have a use case that results in modifications being silently ignored? If so, I will be happy to look at ways to address it.

• You flagged this item as spam.
  

  Andrea Campi October 12th, 2010 @ 06:45 AM

  • Tag changed from “activerecord, patch” to “3.0, activerecord, edge, patch”
• 

  Jeff Kreeftmeijer October 15th, 2010 @ 07:15 AM

  • Tag cleared.

  Automatic cleanup of spam.

• You flagged this item as spam.
  

  Andrea Campi October 16th, 2010 @ 08:47 PM

  • Tag set to “3.0, activerecord, patch”
• 

  Jeff Kreeftmeijer October 19th, 2010 @ 07:09 AM

  • Tag cleared.

  Automatic cleanup of spam.

• 

  Ryan Bigg October 21st, 2010 @ 03:40 AM

  Automatic cleanup of spam.

• 

  Santiago Pastorino February 9th, 2011 @ 12:31 AM

  • State changed from “incomplete” to “open”

  This issue has been automatically marked as stale because it has not been commented on for at least three months.

  The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

  Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

• 

  Santiago Pastorino February 9th, 2011 @ 12:31 AM

  • State changed from “open” to “stale”

• You flagged this item as spam.
  

  bingbing March 26th, 2011 @ 01:19 AM

  gucci watches