#5916 Wrong variable quoted in dbconsole error - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#5916 open

Wrong variable quoted in dbconsole error

Reported by David Kelso | November 4th, 2010 @ 08:02 AM

When using an unknown database adapter, rails prints an error when running the db console (rails dbconsole) because it doesn't know the command to run. The error message incorrectly quotes the database name instead of the adapter.

This is my first patch to rails - please let me know if I've done anything incorrectly.

david

Comments and changes to this ticket

You flagged this item as spam.
David Kelso November 4th, 2010 @ 08:05 AM
Patch here
You flagged this item as spam.
David Kelso November 4th, 2010 @ 08:08 AM
- no changes were found...
- dbconsole_error.diff 908 Bytes
You flagged this item as spam.
David Kelso November 4th, 2010 @ 08:08 AM
- Tag set to “patch”
Neeraj Singh November 4th, 2010 @ 10:49 AM
- Importance changed from “” to “Low”
+1 Looks good.

can you mention if the patch is against Rails 2.3.10 or Rails3?
You flagged this item as spam.
David Kelso November 4th, 2010 @ 06:47 PM
The patch is against rails 3 edge. Is there a way to specify that with tags?
Santiago Pastorino February 5th, 2011 @ 08:56 PM
- State changed from “new” to “open”
This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
Santiago Pastorino February 5th, 2011 @ 08:56 PM
- State changed from “open” to “stale”
You flagged this item as spam.
David Kelso February 5th, 2011 @ 10:38 PM
- State changed from “stale” to “open”
[state:open]

Yes, I can still reproduce the error on both stable and master. The patch still applies cleanly to both.
It's a simple one line change. What is the best way to get this sort of thing committed?
rails May 7th, 2011 @ 01:00 AM
This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
rails May 7th, 2011 @ 01:00 AM
- State changed from “open” to “stale”
You flagged this item as spam.
David Kelso May 10th, 2011 @ 09:31 AM
- State changed from “stale” to “open”
[state:open]

C'mon guys. It's a one line patch.