This project is archived and is in readonly mode.
Allow customization of form class on button_to
Reported by Andrei Bocan | November 24th, 2010 @ 07:06 PM
Hello hello gents,
I'll describe the issue I was having with button_to
succinctly:
Say you've got two actions on a resource that require posts. Flag and Delete, for instance.
These two would both be posts, so the natural fit for this would
be two button_tos, in order to allow non-js clients to
use the features as well.
Now, in order to differentiate between the two in our javascript handlers, we'd require the ability to set some sort of class, to get to the elements easily.
Right now, the only class that you can set is the one of the
submit button. The proper way to hook javascript into this would be
to get the form, and hook its submit event. Only having a
customizable class on the submit button leads to awkward css rules
such as form:has(.my-widget), which just feel kind of
dirty.
This patch adds the :form_class modifier
button_to.
You'll find the patch attached, and the link to the pull request on github is https://github.com/rails/rails/pull/108 in case that's easier for anyone.
Comments and changes to this ticket
-
rails February 25th, 2011 @ 12:00 AM
- State changed from “new” to “open”
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
rails February 25th, 2011 @ 12:00 AM
- State changed from “open” to “stale”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Andrei Bocan