Rails Ruby on Rails

Comments and changes to this ticket

• 

  Aditya Sanghi December 1st, 2010 @ 07:56 AM

  • Importance changed from “” to “Low”

  @Mike, Please send failing test and patch as per contributor's guide http://rails.lighthouseapp.com/projects/8994/sending-patches

• 

  Aaron Patterson December 8th, 2010 @ 11:07 PM

  I've been investigating this, and it looks like if you set ActiveRecord::Base.time_zone_aware_attributes to true, the problem goes away.

  I checked out the v3.0.0 tag, and this test also fails in Rails 3.0.0.

  Here is a video of the test failing on 3.0.0:

  http://www.youtube.com/watch?v=nrrWA7c9L1c

  Here is a video of the test passing with time zone aware attributes:

  http://www.youtube.com/watch?v=Q3UV-oCEmP4

  I'm not convinced that there has been a regression during Rails 3.0.x. I do agree this is strange behavior. Given the "time_zone_aware_attributes" method, I wonder if this strange behavior is expected? It seems to me "time_zone_aware_attributes" should always be set to true, shouldn't it?

• You flagged this item as spam.
  

  Mike Dvorkin December 8th, 2010 @ 11:49 PM

  Ah, and I was about to submit a patch :-). I'm happy with ActiveRecord::Base.time_zone_aware_attributes approach and it certainly makes sense to set it to true by default.

  I haven't run the tests against 3.0.0 so it's hard to say why they fail without looking into it (maybe Base.time_zone_aware_attributes should be explicitly set). But in any case, I've noticed this whole formatting discrepancy because of failing specs in my app after Rails 3.0.3 upgrade.

• You flagged this item as spam.
  

  Espen Antonsen December 9th, 2010 @ 03:18 AM

  Seems ActiveRecord::Base.time_zone_aware_attributes is set to true by default. But I still get the error when it is set to true as it was in my project.
  Adding 'raw_value = raw_value.in_time_zone if raw_value.respond_to?(:in_time_zone)' as Mike suggests in his gist fixes the problem. But that is not necessary in 3.0.1 where this problem does not occur. Strange. What could be the cause? Also, as mention in ticket 6054 this problem does not occur with to_json.

• You flagged this item as spam.
  

  Espen Antonsen December 9th, 2010 @ 03:32 AM

  Aaron: Your video of the test passing is marked as private. http://www.youtube.com/watch?v=Q3UV-oCEmP4

• You flagged this item as spam.
  

  Mike Dvorkin December 9th, 2010 @ 04:29 AM

  Aaron, unfortunately flipping ActiveRecord::Base.time_zone_aware_attributes doesn't seem to affect datetime formatting. Please see https://gist.github.com/734332 (view raw).

  Let me follow-up with a patch...

• You flagged this item as spam.
  

  Espen Antonsen December 9th, 2010 @ 04:34 AM

  Mike: thanks for the update, but with your patch keep in mind that the fix you provided earlier by changing the value in ActiveModel::Serializers::Xml::Serializer::Attribute was not necessary in earlier versions. So I assume the problem must originate somewhere else?

• You flagged this item as spam.
  

  Mike Dvorkin December 9th, 2010 @ 04:43 AM

  • Tag changed from “activemodel, to_xml” to “activemodel, patch, to_xml”

  Here's the patch ;-)

  • xml-serializer-with-timezone.diff 2.5 KB
• 

  Repository December 9th, 2010 @ 08:07 AM

  • State changed from “new” to “resolved”

  (from [f572a02b94ce85bb8db64e838aa159cf3ef4b1fa]) Take into account current time zone when serializing datetime values [#6096 state:resolved]

  Signed-off-by: José Valim jose.valim@gmail.com
  https://github.com/rails/rails/commit/f572a02b94ce85bb8db64e838aa15...

• 

  Repository December 9th, 2010 @ 10:33 AM

  (from [6dcde27f3aeb499b0776b447cde82c5e50fc8ede]) Take into account current time zone when serializing datetime values [#6096 state:resolved]

  Signed-off-by: José Valim jose.valim@gmail.com
  https://github.com/rails/rails/commit/6dcde27f3aeb499b0776b447cde82...

• You flagged this item as spam.
  

  bingbing March 26th, 2011 @ 01:40 AM

  omega watch