This project is archived and is in readonly mode.

#6106 ✓stale
Mike Ragalie

Add an #unmark_for_destruction method to ActiveRecord::AutosaveAssociation

Reported by Mike Ragalie | December 3rd, 2010 @ 06:02 AM

At the moment, the only way to clear a mark for destruction from an association is to use #reload. This method also queries the database again and resets the attributes on the model. It is preferable to have an unmark_for_destruction method that accomplishes just the clearing of the flag.

To give an example of how this is helpful: if a method's default behavior is to destroy all associated records, except for a few that match certain characteristics, it is more intuitive to mark them all for destruction and then unmark the matching records.

I've attached a patch with tests.


Comments and changes to this ticket

  • Mike Ragalie

    Mike Ragalie December 3rd, 2010 @ 06:14 AM

    tagged:activerecord tagged:autosave tagged:associations tagged:patch

  • Mike Ragalie

    Mike Ragalie December 3rd, 2010 @ 06:15 AM

    • Tag set to activerecord, associations, autosave, patch

    [tagged:activerecord tagged:autosave tagged:associations tagged:patch]

  • rails

    rails March 4th, 2011 @ 12:00 AM

    • State changed from “new” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • rails

    rails March 4th, 2011 @ 12:00 AM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket