Rails Ruby on Rails

Comments and changes to this ticket

• 

  Neeraj Singh December 4th, 2010 @ 04:13 AM

  • Importance changed from “” to “Low”

  I think it is a bug. Please feel free to attach a patch for 3.0.3. Patches for 2.3 branch is a littler harder to get accepted since that is a maintenance branch.

• You flagged this item as spam.
  

  coffeeaddict_nl December 6th, 2010 @ 06:08 PM

  After some further investigation as to where to place this patch, it turns out that update_counters in ActiveRecord::Locking::Optimistic::ClassMethods overrides the version from ActiveRecord::CounterCache and just inserts the lock_column as one of the counters.

  This brings to light the question whether it is valid to call the observers on counters...

  Imho it is. I use counters for stock and it would seem only natural that a change in stock would trigger orders to be placed in backorder (or released from it) but there could be counter arguments; The behaviour is no longer expected as it hasn't occurred before and people rely on the fact the update_counters does not call observers.

• 

  Neeraj Singh December 9th, 2010 @ 02:30 AM

  Can you attach a failing test. I think it is a bug. It is not documented and updating counter should fire callback. Client can do whatever it wants to do.

  No need to provide patch for 2.3.x branch . Just work on rails edge.

• 

  rails March 14th, 2011 @ 12:00 AM

  • Tag changed from “activerecord::locking::optimistic::classmethods, callback, observer, update_counters_with_locks” to “activerecordlockingoptimisticclassmethods, callback, observer, update_counters_with_locks”
  • State changed from “new” to “open”

  This issue has been automatically marked as stale because it has not been commented on for at least three months.

  The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

  Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

• 

  rails March 14th, 2011 @ 12:00 AM

  • State changed from “open” to “stale”

• You flagged this item as spam.
  

  klkk May 23rd, 2011 @ 03:14 AM

  www.louisvuittonline.com