#6196 [PATCH] Improve support for non-standard domain names - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#6196 ✓committed

[PATCH] Improve support for non-standard domain names

Reported by Ravil Bayramgalin | December 19th, 2010 @ 07:57 PM | in 3.1

Currently when setting domain :all option Rails uses regexp which handles correctly australian and uk styles tld. It is plenty for default behavior, but sometimes we want to use different logic.

For example when dealing with domain like www.app.me the cookie will be set for .www.app.me domain which is not correct. Another example darberry.com.ua - it will be set as .com.ua. And there are plenty of exceptions like this as you can see at http://publicsuffix.org/list.

So I propose a couple of patches to add more flexibility.

First patch adds support for supplying several domain names to cookies. For example,

:domain => %w(.app.me .darberry.com.ua)

And it will set appropriate domain for all cookies.

Second patch adds more flexibility when you deal with wildcard subdomains and they are not correctly parsed by default domain regexp. For example, your application is deployed to subdomain.hosting.com and your application supports subdomains on top so you want to share cookies only between subdomains on top of your application. It's easy to achieve by using custom tld length:

:domain => :all, :tld_length => 3

and it will correctly set cookies domain to .subdomain.hosting.com

https://gist.github.com/734913 - first patch
https://gist.github.com/747615 - second patch

If there is anything I could do to improve these patches I would be happy to do it.

Comments and changes to this ticket

You flagged this item as spam.
Ravil Bayramgalin December 25th, 2010 @ 02:50 PM
- Assigned user changed from “José Valim” to “Santiago Pastorino”
Jose has reviewed patch and said it looks fine, but since he's ill right now, he asked to assign it to Santiago for further review.
Santiago Pastorino January 9th, 2011 @ 09:13 PM
- Milestone set to “3.1”
- State changed from “new” to “open”
- Importance changed from “” to “Low”
You flagged this item as spam.
Ravil Bayramgalin January 14th, 2011 @ 11:53 PM
- Assigned user changed from “Santiago Pastorino” to “Piotr Sarnacki”
Santiago is going on vacation and asked to change it to Piotr :)
José Valim January 21st, 2011 @ 12:17 PM
- State changed from “open” to “committed”
- Assigned user changed from “Piotr Sarnacki” to “José Valim”