This project is archived and is in readonly mode.
Action cache filter code incorrectly renders nil response body if response is non-cacheable
-
Chris Mear
+1 Test looks good.
-
Tekin
+1 got bit by this today.
-
Jeff Kreeftmeijer
- State changed from new to verified
- Assigned user set to Santiago Pastorino
- Importance changed from to Low
Verified. Patch applies to master cleanly and tests pass. Test is good and fails without the fix. :)
We might want to push this one to stable too. Santiago, what do you think? :)
-
Josh Kalderimis
- Tag changed from actionpack, caches_action, caching, patch to actionpack, patch
+1 for master and stable, seems like a good correction to both!
-
Lenary
+1 applies cleanly to 3-0-stable and to master cleanly on my machine, and doesn't even break anything!
-
Kamal Fariz
+1
-
Wayne See
+1 from me too. This bug causes the issues raised in #5773 ActionController crashes when trying to render head 406 with caches_action and #5586 caches_action breaks with Rack error on redirects and the patch I submitted for #5773 ActionController crashes when trying to render head 406 with caches_action is the similar to this. I'll mark #5773 ActionController crashes when trying to render head 406 with caches_action as duplicate to help with housekeeping.
-
Repository
- State changed from verified to committed
(from [2ee55557440a644453482a678e4ff08a4b5ebd3e]) Fix Action caching bug where an action that has a non-cacheable response always renders a nil response body. It now correctly renders the response body.
Note that only GET and HTTP 200 responses can be cached.
[#6480 Action cache filter code incorrectly renders nil response body if response is... state:committed]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
https://github.com/rails/rails/commit/2ee55557440a644453482a678e4ff... -
Repository
(from [beec6c8b2abfd3286bd7c0a1c7ecb04686af6448]) Fix Action caching bug where an action that has a non-cacheable response always renders a nil response body. It now correctly renders the response body.
Note that only GET and HTTP 200 responses can be cached.
[#6480 Action cache filter code incorrectly renders nil response body if response is... state:committed]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
https://github.com/rails/rails/commit/beec6c8b2abfd3286bd7c0a1c7ecb...
