This project is archived and is in readonly mode.
submit_tag :confirm bug
Reported by Lawrence Pit | July 19th, 2008 @ 06:54 AM | in 2.x
When doing any of the following:
submit_tag "Save", :onclick => "alert('x');", :confirmation => "Sure?"
submit_tag "Save", :disable_with => "Saving...", :confirmation => "Sure?"
the confirmation isn't executed. This patch fixes that bug.
Comments and changes to this ticket
-
Clemens Kofler July 19th, 2008 @ 09:50 AM
You should use :confirm and not :confirmation, otherwise you might confuse people (you confused me ;-)).
As for the patch, this looks like a good idea to me. Is the "return true" really necessary?
-
Lawrence Pit July 19th, 2008 @ 11:42 AM
Ah yeah, sorry, the example in this ticket should indeed use :confirm. The patch is correct though. I like the return true to be explicit.
-
Lawrence Pit July 21st, 2008 @ 02:43 AM
- Title changed from “submit_tag :confirmation bug” to “submit_tag :confirm bug”
-
josh October 28th, 2008 @ 04:29 PM
- State changed from “new” to “open”
I think ran into the same problem myself.
-
Pratik March 6th, 2009 @ 05:56 PM
- Assigned user set to “josh”
-
Repository March 7th, 2009 @ 07:33 PM
- State changed from “open” to “resolved”
(from [77f7d98e38dddf72890c80b4e4b2e088bb76d111]) submit_tag with confirmation and disable_with [#660 state:resolved]
Signed-off-by: Joshua Peek josh@joshpeek.com http://github.com/rails/rails/co...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Clemens Kofler
Pratik
Attachments
Tags
Referenced by
-
660
submit_tag :confirm bug
(from [77f7d98e38dddf72890c80b4e4b2e088bb76d111]) submit_...