This project is archived and is in readonly mode.
Deprecating ActiveRecord::Base#attributes=
Reported by Hampton Catlin | July 30th, 2008 @ 12:18 AM | in 2.x
This is an extremely ugly method that is not ruby like enough and its been around since the beginning.
We discussed this in #ruby-contrib and everyone agreed. So, I branched and fixed it.
The new method that merges in attributes is ActiveRecord::Base#merge_attributes instead of ActiveRecord::Base#attributes= which is misleading because it looks like assignment.
I have added a deprecation warning to the use of ActiveRecord::Base#attributes=
There is a pull request on GitHub for this patch.
Comments and changes to this ticket
-
Rick July 30th, 2008 @ 01:15 AM
- State changed from new to open
Hey, we upload patches to Lighthouse instead of using pull requests. Pull requests are private, and publicly uploaded patches allow everyone that doesn't happen to get a pull request to participate in the testing of the patch.
-
Hampton Catlin July 30th, 2008 @ 01:30 AM
It won't let me upload a patch. Keeps failing.
On Tue, Jul 29, 2008 at 8:15 PM, Lighthouse wrote:
-
Pratik August 22nd, 2008 @ 02:46 AM
- State changed from open to wontfix
I think we need a discussion on this on mailing list before we deprecate it.
Thanks.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>