Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

refactor Filter predicate methods to use inheritance

#815

The Filter predicate methods #before?, #after? and #around? are defined in the Filter superclass and make explicit comparisons to subclasses. Cleaned them up to use inheritance to avoid the superclass having to know too much about subclasses.

Reported by Josh Susser · August 13th, 2008 @ 06:50 AM

State: resolved
Milestone: 2.x
Assigned to: nobody
Importance: none

Activity

  1. ymendel
    ymendel

    +1

    OO isn't too hard a concept

    August 13th, 2008 @ 05:31 PM

  2. Rick Bradley
    Rick Bradley
    1. Also, more like this. Rick

    August 13th, 2008 @ 05:32 PM

  3. Rein Henrichs
    Rein Henrichs

    +1 That's what she said.

    August 13th, 2008 @ 06:27 PM

  4. Tim Connor
    Tim Connor

    +1 May I have another, sir?!

    August 13th, 2008 @ 06:36 PM

  5. Repository
    Repository
    • State changed from new to resolved

    (from [2561be005b1180883ccf1d0f7ad38858d9348064]) Refactor Filter predicate methods to use inheritance. [#815 refactor Filter predicate methods to use inheritance state:resolved]

    Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...

    August 13th, 2008 @ 09:53 PM