This project is archived and is in readonly mode.
Fixed Return-Path in ActionMailer
Reported by Mutwin Kraus | August 27th, 2008 @ 12:01 PM | in 2.x
When the mail header 'return-path' was set, sending mail resulted in this Exception:
Net::SMTPSyntaxError: 501 <email@example.com>: missing or malformed local part
This patch strips the additional < and > from return-path if it's set as the sender address.
Comments and changes to this ticket
-
Jonathan S. Katz October 6th, 2008 @ 07:07 AM
Unfortunately, that fix broke when I tried running it on my fork on Rails due to the class-type of the return-path header used by TMail. I propose a slightly different fix - please see attached.
-
Pratik January 18th, 2009 @ 05:58 AM
- State changed from “new” to “incomplete”
- Assigned user set to “Pratik”
Patch is missing tests.
Thanks.
-
Jonathan S. Katz February 4th, 2009 @ 07:45 PM
The test is relatively straightforward, I just never had a chance to write it. Unfortunately, due to the amount of time this took and my need to avoid custom-Rails patches, I've switched to using MailFactory and a lightweight mailer that I wrote to handle my present email needs.
If you would like, I can still write up some tests.
Thanks,
Jonathan
-
Pratik February 4th, 2009 @ 07:55 PM
- Assigned user changed from “Pratik” to “Michael Klishin (antares)”
Yes please.
Assigning to Michael as he has more experience with the Mailer stuff.
Thanks.
-
Frederick Cheung February 6th, 2009 @ 01:00 AM
- State changed from “incomplete” to “duplicate”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Jonathan S. Katz
Michael Klishin (antares)
Mutwin Kraus
Pratik