This project is archived and is in readonly mode.
can't run actionpack tests directly due to errant require
-
DHH
- State changed from new to invalid
- Tag changed from actionpack, tests to actionpack, patch, tests
I can't replicate that on master? Seems to work here.
-
David Chelimsky
Bummer. I just followed my instructions above (starting with a clean clone) and got the same result.
Any chance you've got active_support's lib directory on your path? That could explain why you don't get this error.
-
DHH
I do have the gems installed. Maybe that's it? Do you not have any Rails gems installed?
-
David Chelimsky
I do:
actionmailer (2.1.1, 2.1.0, 1.3.6) actionpack (2.1.1, 2.1.0, 1.13.6) actionwebservice (1.2.6) activerecord (2.1.1, 2.1.0, 1.15.6) activeresource (2.1.1, 2.1.0) activesupport (2.1.1, 2.1.0, 1.4.4) rails (2.1.1, 2.1.0, 1.2.6)
So that's probably not it by itself. I was thinking more like you just had it added to your PATH in your .profile or .bash_login or whatever you might be using.
Could also be a fluke of load order - I see, for example, in lib/action_controller.rb:
begin require 'active_support' rescue LoadError activesupport_path = "#{File.dirname(__FILE__)}/../../activesupport/lib" if File.directory?(activesupport_path) $:.unshift activesupport_path require 'active_support' end endSo if that file gets loaded before lib/action_controller/request.rb (which is the source of the load error I'm getting when it tries to require 'active_support/memoizable'), you wouldn't see the error I'm seeing
Can you delete line 2 of test/abstract_unit and still run the tests? That would support this load order theory.
-
Rob Sanheim
We are also seeing the above issue on our local builds of Rails.
Can David's fix above be applied? It looks like it maintains the exact behavior and fixes the load order issue.
-
Michael Koziarski
- Assigned user set to josh
-
Michael Koziarski
- Assigned user changed from josh to Jeremy Kemper
Caused by http://github.com/rails/rails/co... ?
-
madlep
I've been seeing this one as well.
Patch attached that incorporates David Chelimsky's fix, and a similar fix for http://rails.lighthouseapp.com/p... , which has the same root cause.
-
Michael Koziarski
- State changed from invalid to open
-
Repository
- State changed from open to committed
(from [2def5b6314e1fbbaa789d1311e488ffac498703d]) Fixed load path for actionmailer and activesupport tests to always load from local lib files.
[#983 state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/co...
