This project is archived and is in readonly mode.
can't run actionpack tests directly due to errant require
Reported by David Chelimsky | September 6th, 2008 @ 01:06 PM | in 2.x
git clone git://github.com/rails/rails.git
cd rails
cd actionpack
rake test_action_pack
... results in ...
no such file to load -- active_support/memoizable (MissingSourceFile)
Fix can be found in http://github.com/dchelimsky/rai...
Comments and changes to this ticket
-
DHH September 10th, 2008 @ 05:20 AM
- State changed from new to invalid
- Tag changed from actionpack, tests to actionpack, patch, tests
I can't replicate that on master? Seems to work here.
-
David Chelimsky September 10th, 2008 @ 05:27 AM
Bummer. I just followed my instructions above (starting with a clean clone) and got the same result.
Any chance you've got active_support's lib directory on your path? That could explain why you don't get this error.
-
DHH September 10th, 2008 @ 05:32 AM
I do have the gems installed. Maybe that's it? Do you not have any Rails gems installed?
-
David Chelimsky September 10th, 2008 @ 05:50 AM
I do:
actionmailer (2.1.1, 2.1.0, 1.3.6) actionpack (2.1.1, 2.1.0, 1.13.6) actionwebservice (1.2.6) activerecord (2.1.1, 2.1.0, 1.15.6) activeresource (2.1.1, 2.1.0) activesupport (2.1.1, 2.1.0, 1.4.4) rails (2.1.1, 2.1.0, 1.2.6)
So that's probably not it by itself. I was thinking more like you just had it added to your PATH in your .profile or .bash_login or whatever you might be using.
Could also be a fluke of load order - I see, for example, in lib/action_controller.rb:
begin require 'active_support' rescue LoadError activesupport_path = "#{File.dirname(__FILE__)}/../../activesupport/lib" if File.directory?(activesupport_path) $:.unshift activesupport_path require 'active_support' end end
So if that file gets loaded before lib/action_controller/request.rb (which is the source of the load error I'm getting when it tries to require 'active_support/memoizable'), you wouldn't see the error I'm seeing
Can you delete line 2 of test/abstract_unit and still run the tests? That would support this load order theory.
-
Rob Sanheim September 12th, 2008 @ 08:04 PM
We are also seeing the above issue on our local builds of Rails.
Can David's fix above be applied? It looks like it maintains the exact behavior and fixes the load order issue.
-
Michael Koziarski September 15th, 2008 @ 04:44 PM
- Assigned user set to josh
-
Michael Koziarski September 15th, 2008 @ 04:49 PM
- Assigned user changed from josh to Jeremy Kemper
Caused by http://github.com/rails/rails/co... ?
-
madlep October 4th, 2008 @ 09:18 AM
I've been seeing this one as well.
Patch attached that incorporates David Chelimsky's fix, and a similar fix for http://rails.lighthouseapp.com/p... , which has the same root cause.
-
Michael Koziarski October 4th, 2008 @ 12:31 PM
- State changed from invalid to open
-
Repository October 4th, 2008 @ 03:58 PM
- State changed from open to committed
(from [2def5b6314e1fbbaa789d1311e488ffac498703d]) Fixed load path for actionmailer and activesupport tests to always load from local lib files.
[#983 state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/co...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Attachments
Tags
Referenced by
- 1052 failure in ActionMailer tests due to load issue http://rails.lighthouseapp.com/p...
- 983 can't run actionpack tests directly due to errant require [#983 state:committed]
- 1052 failure in ActionMailer tests due to load issue Rob, did the fix for #983 fix this for you ?
- 1620 Fix for breaking Activeresource unit tests Fixed issue, and tests now run successfully. Similar to ...