Rails Ruby on Rails → 2.x

Comments and changes to this ticket

• 

  Maxim Kulkin September 10th, 2008 @ 08:11 PM

  • no changes were found...

  • render_partial_collection_inline_spacer.diff 4.6 KB

• You flagged this item as spam.
  

  Maxim Kulkin September 10th, 2008 @ 08:40 PM

  • Title changed from “render partial collection with inline spacer” to “[PATCH] render partial collection with inline spacer”
• 

  josh September 11th, 2008 @ 04:39 PM

  • Assigned user set to “Pratik”

  I think it would be nicer just to type check "options[:spacer_template].is_a?(String)"

  @Pratik Are spacer templates going away?

• You flagged this item as spam.
  

  Maxim Kulkin September 11th, 2008 @ 08:20 PM

  Checking type of options[:spacer_template] won't work because both partial name and inline spacer are strings, so it won't be possible to distinguish those two. Also, that _template suffix is not ideal for naming inline spacer. I was also considering :spacer_inline or :spacer_text as alternatives.

  If you plan to move spacer templates away, what should be used instead ? Or render partial collection will also be deprecated ?

• 

  josh September 12th, 2008 @ 01:49 AM

  Duh! of course they are both strings :)

  I think the :spacer_template was going be moved into a plugin or something, not totally sure. Waiting for Pratik's response.

• 

  Pratik September 12th, 2008 @ 08:48 AM

  • Title changed from “[PATCH] render partial collection with inline spacer” to “render partial collection with inline spacer”
  • State changed from “new” to “wontfix”

  Hey,

  Plan is to deprecate spacer templates and move them to plugins. Josh/Ryan also did some refactoring to make writing plugin easier. #830 and #881 are relevant tickets,