Rails Ruby on Rails

Comments and changes to this ticket

• You flagged this item as spam.
  

  Leonardo Pinheiro October 8th, 2008 @ 07:24 PM

  I suggest this patch be put on 2.1.2.

• You flagged this item as spam.
  

  Kane October 9th, 2008 @ 11:11 PM

  this patch also needs to add the sao paulo definition to active_support\vendor\tzinfo

  • Sao_Paulo.rb 7.8 KB

• You flagged this item as spam.
  

  Marcus Derencius October 10th, 2008 @ 02:38 PM

  Here is the patch including Sao_Paulo.rb definition sent my Kane.

  Kane, If you want, you can edit the patch and define your email as the author of Sao_Paulo.rb file. Fell free.

  • brasilia_timezone.v2.patch 10 KB

• You flagged this item as spam.
  

  Marcus Derencius October 10th, 2008 @ 02:42 PM

  Sent by kane, not my. :)

• 

  Pratik October 14th, 2008 @ 01:32 PM

  • Assigned user set to “Geoff Buesing”
  • Milestone cleared.

  Oops. Could you please submit a patch to tzinfo project ? Rails doesn't really tend to monkey patch vendored gems. And the tzinfo maintainer Philip Ross has been very prompt in my experience.

  Once it gets committed to tzinfo, we could bump up the vendored version in Rails and apply this patch.

  Thanks!

• 

  Pratik October 14th, 2008 @ 01:33 PM

  You could submit the tzinfo patch at http://rubyforge.org/projects/tz...

• 

  Geoff Buesing October 14th, 2008 @ 02:38 PM

  As I understand it, this patch doesn't actually change TzInfo -- it just points the ActiveSupport::TimeZone['Brasilia'] instance to TzInfo's existing "America/Sao_Paulo" definition instead of the "America/Argentina/Buenos_Aires" definition.

  (Fyi, the version of TzInfo bundled in ActiveSupport includes a subset of the zones included in the TzInfo gem.)

  Could the authors of this patch confirm that the included time zone definition is pulled straight from TzInfo without any changes?

• You flagged this item as spam.
  

  Kane October 14th, 2008 @ 04:36 PM

  hi Sao_Paulo.rb is directly from tzinfo 0.3.11

  i suggest to commit the first patch from marcus derencius and to update the bundled tzinfo to 0.3.11 and include the nessecary definitions.

• 

  Geoff Buesing October 14th, 2008 @ 08:23 PM

  @Kane - makes sense.

• 

  Pratik October 17th, 2008 @ 10:45 PM

  Makes sense. Thanks for the info!

• 

  Repository October 17th, 2008 @ 10:46 PM

  • State changed from “new” to “resolved”

  (from [4a256d7769306a07beab936fd01c95ae621c9984]) Fix Brasilia timezone. [#1180 state:resolved] http://github.com/rails/rails/co...

• 

  Repository October 17th, 2008 @ 10:46 PM

  (from [18e7bf28655cfd9253239963256609edb9fa5a53]) Fix Brasilia timezone. [#1180 state:resolved] http://github.com/rails/rails/co...

• You flagged this item as spam.
  

  Marcus Derencius October 18th, 2008 @ 03:17 PM

  thanks you.