#1180 Brasilia Timezone - Ruby on Rails

Leonardo Pinheiro

I suggest this patch be put on 2.1.2.

October 8th, 2008 @ 07:24 PM

Kane

this patch also needs to add the sao paulo definition to active_support\vendor\tzinfo

Sao_Paulo.rb 7.81 KB

October 9th, 2008 @ 11:11 PM

Marcus Derencius

Here is the patch including Sao_Paulo.rb definition sent my Kane.

Kane, If you want, you can edit the patch and define your email as the author of Sao_Paulo.rb file. Fell free.

brasilia_timezone.v2.patch 9.98 KB

October 10th, 2008 @ 02:38 PM

Marcus Derencius

Sent by kane, not my. :)

October 10th, 2008 @ 02:42 PM

Pratik

Assigned user set to Geoff Buesing
Milestone cleared.

Oops. Could you please submit a patch to tzinfo project ? Rails doesn't really tend to monkey patch vendored gems. And the tzinfo maintainer Philip Ross has been very prompt in my experience.

Once it gets committed to tzinfo, we could bump up the vendored version in Rails and apply this patch.

Thanks!

October 14th, 2008 @ 01:32 PM

Pratik

You could submit the tzinfo patch at http://rubyforge.org/projects/tz...

October 14th, 2008 @ 01:33 PM

Geoff Buesing

As I understand it, this patch doesn't actually change TzInfo -- it just points the ActiveSupport::TimeZone['Brasilia'] instance to TzInfo's existing "America/Sao_Paulo" definition instead of the "America/Argentina/Buenos_Aires" definition.

(Fyi, the version of TzInfo bundled in ActiveSupport includes a subset of the zones included in the TzInfo gem.)

Could the authors of this patch confirm that the included time zone definition is pulled straight from TzInfo without any changes?

October 14th, 2008 @ 02:38 PM

Kane

hi Sao_Paulo.rb is directly from tzinfo 0.3.11

i suggest to commit the first patch from marcus derencius and to update the bundled tzinfo to 0.3.11 and include the nessecary definitions.

October 14th, 2008 @ 04:36 PM

Geoff Buesing

@Kane - makes sense.

October 14th, 2008 @ 08:23 PM

Pratik

Makes sense. Thanks for the info!