This project is archived and is in readonly mode.
Make AS::Multibyte::Chars#slice! behave more like String#slice!
-
Manfred Stienstra
- Assigned user set to Manfred Stienstra
-
Manfred Stienstra
Patch looks great, thanks. I've modified it slightly to put more information in the commit message.
-
George Ogata
Cool, thanks. Does this mean it'll be merged in?
There are a few other methods that differ from String. Specifically, some of those bang methods should return nil if no modification occurred. I can patch those too if this gets the green light.
George.
-
Manfred Stienstra
Let's hope so (: Unfortunately I can't push to the main repository myself, but I will make sure someone commits it.
I was thinking about getting the String specs from RubySpec and using those in the Multibyte tests to make sure it works as much like String as possible.
-
George Ogata
Nice idea! :)
-
Pratik
- Assigned user changed from Manfred Stienstra to Pratik
Hey Manfred,
Is this ready to be committed ?
Thanks.
-
Manfred Stienstra
Yeah, you can commit it if you want.
-
Repository
- State changed from new to resolved
(from [74387884819e8b6e16c3f67388610b8d1192cb4d]) Make Chars#slice! behave more like String#slice! [#1243 state:resolved]
- Chars#slice! now returns the slice instead of itself
- Chars#slice! now removes the slice from itself
Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...
