This project is archived and is in readonly mode.

#1319 ✓committed
Aliaksey Kandratsenka

Don't eval recognize_optimized as part of recognition_optimization.rb. It produces meaningless line numbers.

Reported by Aliaksey Kandratsenka | November 3rd, 2008 @ 10:04 AM | in 2.x

Passing FILE and LINE__ in eval of recognize_optimized mixes lines of recognition_optimization.rb and lines of generated code. This is not good.

This also produces line numbers greater than recognition_optimization.rb has, which causes rcov to trash memory outside of it's coverage counting arrays.

Comments and changes to this ticket

  • Pratik

    Pratik November 3rd, 2008 @ 11:54 AM

    • Assigned user set to “Michael Koziarski”
    • Title changed from “[patch] don't eval recognize_optimized as part of recognition_optimization.rb. It produces meaningless line numbers.” to “Don't eval recognize_optimized as part of recognition_optimization.rb. It produces meaningless line numbers.”
  • Repository

    Repository November 6th, 2008 @ 07:54 PM

    • State changed from “new” to “committed”

    (from [099f10679ec6d9ead9606cac2f843e854787db0c]) Don't eval recognize_optimized use FILE and LINE in the optimised recognition code.

    It produces meaningless line numbers. This also easily produces line numbers greater than recognition_optimization.rb have, which causes rcov to trash memory outside of it's coverage counting arrays.

    [#1319 state:committed] Signed-off-by: Michael Koziarski michael@koziarski.com http://github.com/rails/rails/co...

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Attachments

Tags

Referenced by

Pages