#1345 Array#to_xml accepts :root_attrs - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#1345 ✓wontfix

Array#to_xml accepts :root_attrs

Reported by Ernesto Jiménez | November 7th, 2008 @ 06:50 PM | in 2.x

You can define root attributes using :root_attrs option:

@projects.to_xml(:root_attrs => {:page => 1, :per_page => 3})

<?xml version="1.0" encoding="UTF-8"?>
<projects page="1" per_page="3" type="array">
  <project>
    <name>project 1</name>
  </project>
  <project>
    <name>project 2</name>
  </project>
  <project>
    <name>project 3</name>
  </project>
</projects>

This is useful for paginated XMLs

array_to_xml_with_root_attrs.diff 5 KB

Comments and changes to this ticket

You flagged this item as spam.
Luismi Cavallé November 7th, 2008 @ 10:14 PM
+1 Useful patch, tests pass and docs
You flagged this item as spam.
Raul Murciano November 8th, 2008 @ 11:04 AM
+1
You flagged this item as spam.
Juanjo Bazán November 8th, 2008 @ 11:26 AM
- Tag set to “verified”
Nice addition. Works for me and docs look good.
You flagged this item as spam.
Emili Parreño November 8th, 2008 @ 07:48 PM
+1 Tests and docs ok
You flagged this item as spam.
Deleted User November 8th, 2008 @ 08:51 PM
+1, everything ok and is useful
DHH November 9th, 2008 @ 06:28 PM
- State changed from “new” to “wontfix”
The problem is that there won't parity with Hash.from_xml, which is the sister method of to_xml. If you give it your sample string, you'll get {"projects"=>[{"name"=>"project 1"}, {"name"=>"project 2"}, {"name"=>"project 3"}]} back -- in other words, the attributes are just dropped.

Until we find a way of dealing with that, I don't see this as a good fit.
You flagged this item as spam.
Ernesto Jiménez November 10th, 2008 @ 01:27 AM
It actually seems that the problem is with the type="array".

http://gist.github.com/23401

omitting type="array" gets the parameters.

A possible solution might be avoiding type="array" when :root_attrs is set?