Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

auto_link helper fails to parse some URLs with brackets

#1353

Found another URL that auto_link was failing on:

http://connect.oraclecorp.com/se...[q]=green+france&search[type]=Group

Anyway, fixed. Patch attached.

Reported by Rich · November 11th, 2008 @ 03:57 AM

State: committed
Milestone: 2.x
Assigned to: nobody
Importance: none

Activity

  1. Rich
    Rich

    After testing some more, I noticed that with or without this patch, a URL like the following gets parsed improperly. Check out the pastie.

    http://pastie.org/312053

    I'll put in a separate ticket.

    Rich

    November 11th, 2008 @ 04:59 AM

  2. Mislav
    Mislav

    Here is a patch that completely refactors auto_link_urls, fixing this and #1151, #1148 (the last remaining issues about this).

    November 13th, 2008 @ 09:49 PM

  3. Repository
    Repository
    • State changed from new to committed

    (from [4f984c9d0e66601a81cb5ae6e3b50582e6dc0c2d]) auto_link helper: add intelligent ending closing bracket handling. add new tests and reorder new ones for readability

    Signed-off-by: Michael Koziarski michael@koziarski.com [#1353 state:committed] http://github.com/rails/rails/co...

    November 15th, 2008 @ 05:31 PM