Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

auto_link in text_helper.rb doesn't handle some gmail URLS

#3035

gmail URLs (and increasingly other URLs as well) can have important information after an anchor, such as:

https://mail.google.com/mail/#search/%7Bis%3Aunread+is%3Astarred+is...
aft%7D/12272188ec71e0f4

auto_link does not love this URL, only autolinking the \w trailing the # and not everything after that next /, i.e., you get:

https://mail.google.com/mail/#search [linked]

/%7Bis%3Aunread+is%3Astarred+is%3Adraft%7D/12272188ec71e0f4 [plain text, not linked]

I noticed this in an older version of rails, but looking at git it seems that the regexp at issue is the same in both my older version and in current trunk.

Michael, my apologies if you're not actually responsible, but I saw in bug #1353 and others that you have touched/reviewed patches to this code, so thought you might be closest. Thanks.

Reported by Luis Villa · August 11th, 2009 @ 03:43 AM

State: invalid
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. CancelProfileIsBroken
    CancelProfileIsBroken
    • Tag changed from auto_link, text_helper to auto_link, bugmash, text_helper
    • Assigned user cleared.

    September 25th, 2009 @ 12:54 PM

  2. Robert Rouse
    Robert Rouse

    I'm unable to actually reproduce this one. I tried various urls from Gmail.

    September 26th, 2009 @ 01:05 AM

  3. Elad Meidar
    Elad Meidar

    Close this ticket, tried several urls and they all pass.

    attached a test to check this specific example, it passes on 2-3-stable

    September 26th, 2009 @ 02:51 AM

  4. John Pignata
  5. Elomar França
    Elomar França

    -1, can't reproduce. The tests from Elad Meidar passes on 2-3-stable and master.

    September 26th, 2009 @ 04:45 PM

  6. Pat Allan
    Pat Allan
    • Tag changed from auto_link, bugmash, text_helper to auto_link, bugmash, bugmash-review, text_helper

    And -1 from me too, along with Elad's tests passing. I think it's safe to close this (Luis, do you disagree?)

    September 26th, 2009 @ 05:16 PM

  7. sr.iniv.t
    sr.iniv.t

    -1 not reproducible.

    Elad's test passes in 2-3-stable for me too.

    September 26th, 2009 @ 05:47 PM

  8. CancelProfileIsBroken
    CancelProfileIsBroken
    • State changed from new to invalid
    • Tag changed from auto_link, bugmash, bugmash-review, text_helper to auto_link, text_helper

    September 27th, 2009 @ 11:50 AM

  9. CancelProfileIsBroken
    CancelProfileIsBroken
    • Tag changed from auto_link, text_helper to auto_link, bugmash, text_helper

    September 27th, 2009 @ 12:33 PM

  10. Matías Flores
    Matías Flores

    -1 not reproducible

    Applied Elad Meidar's patch in both 2-3-stable and master and in both branches all tests passed as expected.

    September 27th, 2009 @ 07:25 PM